Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(notificaiton/breadcrumb): update styles/remove @extend #10231

Merged
merged 6 commits into from
Mar 15, 2023
Merged

fix(notificaiton/breadcrumb): update styles/remove @extend #10231

merged 6 commits into from
Mar 15, 2023

Conversation

ariellalgilmore
Copy link
Member

Related Ticket(s)

N/A

Description

with update to sass we need to import

Changelog

Changed

  • added styles from react package not coming through

@ariellalgilmore ariellalgilmore requested a review from a team as a code owner March 14, 2023 20:28
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Mar 14, 2023 •
edited
Loading

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/10231/index.html

Built with commit: aba5f01191ba01bd4b28aab74d79271b5f7f552d

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Mar 14, 2023 •
edited
Loading

Deploy preview created for package Carbon:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/10231/index.html

Built with commit: aba5f01191ba01bd4b28aab74d79271b5f7f552d

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Mar 14, 2023 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/10231/index.html

Built with commit: aba5f01191ba01bd4b28aab74d79271b5f7f552d

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/10231/index.html

Built with commit: aba5f01191ba01bd4b28aab74d79271b5f7f552d

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/10231/index.html

Built with commit: aba5f01191ba01bd4b28aab74d79271b5f7f552d

@ariellalgilmore ariellalgilmore changed the base branch from main to release/v1.45.0 March 15, 2023 16:55
annawen1
annawen1 approved these changes Mar 15, 2023
View reviewed changes
Copy link
Member

@annawen1 annawen1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ariellalgilmore ariellalgilmore added the Ready to merge Label for the pull requests that are ready to merge label Mar 15, 2023
@kodiakhq kodiakhq bot merged commit 96affe7 into carbon-design-system:release/v1.45.0 Mar 15, 2023
@ariellalgilmore ariellalgilmore deleted the fix/notification-style-imports branch March 16, 2023 14:34
kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Dec 4, 2023
@ariellalgilmore
fix(notificaiton/breadcrumb): update styles/remove @extend (carbon-de…
37d1f22 
…sign-system#10231)

### Related Ticket(s)

N/A
### Description

with update to `sass` we need to import 

### Changelog

**Changed**

- added styles from react package not coming through


<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Jun 11, 2024
@ariellalgilmore
fix(notificaiton/breadcrumb): update styles/remove @extend (carbon-de…
9f180e0 
…sign-system#10231)

### Related Ticket(s)

N/A
### Description

with update to `sass` we need to import 

### Changelog

**Changed**

- added styles from react package not coming through


<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annawen1 annawen1 annawen1 approved these changes

@kennylam kennylam Awaiting requested review from kennylam kennylam was automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@RichKummer RichKummer Awaiting requested review from RichKummer RichKummer was automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees
No one assigned
Labels
package: carbon web components Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ariellalgilmore @ibmdotcom-bot @annawen1