Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tile): fix expanable content visibility #10203

Merged
merged 2 commits into from
Mar 8, 2023
Merged

fix(tile): fix expanable content visibility #10203

merged 2 commits into from
Mar 8, 2023

Conversation

kennylam
Copy link
Member

@kennylam kennylam commented Mar 8, 2023

Related Ticket(s)

#10202

Description

Fixes styles for tile - expanded content to be visible when tile is expanded.

Changelog

New

  • {{new thing}}

Changed

  • make expanded content visible

Removed

  • {{removed thing}}

@kennylam kennylam requested a review from a team as a code owner March 8, 2023 14:43
@kennylam kennylam requested a review from RichKummer March 8, 2023 14:43
@kennylam kennylam linked an issue Mar 8, 2023 that may be closed by this pull request
[tile]: content not visible when tile is expanded #10202
Closed
2 tasks
@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/10203/index.html

Built with commit: 5278990fbe41a269601a8a25b824cd0b604bf9a0

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package "Carbon:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/10203/index.html

Built with commit: 5278990fbe41a269601a8a25b824cd0b604bf9a0

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/10203/index.html

Built with commit: 5278990fbe41a269601a8a25b824cd0b604bf9a0

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/10203/index.html

Built with commit: 5278990fbe41a269601a8a25b824cd0b604bf9a0

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/10203/index.html

Built with commit: 5278990fbe41a269601a8a25b824cd0b604bf9a0

RichKummer
RichKummer approved these changes Mar 8, 2023
View reviewed changes
Copy link

@RichKummer RichKummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kennylam kennylam added the Ready to merge Label for the pull requests that are ready to merge label Mar 8, 2023
@kodiakhq kodiakhq bot merged commit a71b9f9 into carbon-design-system:main Mar 8, 2023
@kennylam kennylam deleted the fix/tile-expandable-hidden-content-10202 branch March 8, 2023 21:53
@RichKummer RichKummer mentioned this pull request Mar 10, 2023
Closed
kennylam added a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Dec 4, 2023
@kennylam
fix(tile): fix expanable content visibility (carbon-design-system#10203)
dd1092c 
### Related Ticket(s)

carbon-design-system#10202 

### Description

Fixes styles for `tile - expanded` content to be visible when tile is expanded.

### Changelog

**New**

- {{new thing}}

**Changed**

- make expanded content `visible`

**Removed**

- {{removed thing}}

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
kennylam added a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Jun 11, 2024
@kennylam
fix(tile): fix expanable content visibility (carbon-design-system#10203)
30d1d4a 
### Related Ticket(s)

carbon-design-system#10202 

### Description

Fixes styles for `tile - expanded` content to be visible when tile is expanded.

### Changelog

**New**

- {{new thing}}

**Changed**

- make expanded content `visible`

**Removed**

- {{removed thing}}

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RichKummer RichKummer RichKummer approved these changes

Assignees
No one assigned
Labels
package: carbon web components Ready to merge Label for the pull requests that are ready to merge
Projects
Carbon for IBM.com
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[tile]: content not visible when tile is expanded
3 participants
@kennylam @ibmdotcom-bot @RichKummer