HTTPS protocol for ibm.com link in the masthead #9567
Comments
kennylam
assigned kennylam and unassigned jeffchew, RichKummer, ljcarot, IgnacioBecerra and oliviaflory
This was referenced Jan 17, 2023
kodiakhq bot
pushed a commit
that referenced
this issue
Jan 17, 2023
### Related Ticket(s) #9567 ### Description This updates the React masthead logo URL to use `https`. ### Changelog **Changed** - React masthead logo URL changed to use `https` <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "test: e2e": Codesandbox examples and e2e integration tests --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
kennylam
added a commit
to kennylam/carbon-for-ibm-dotcom
that referenced
this issue
Dec 4, 2023
### Related Ticket(s) carbon-design-system#9567 ### Description This updates the React masthead logo URL to use `https`. ### Changelog **Changed** - React masthead logo URL changed to use `https` <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "test: e2e": Codesandbox examples and e2e integration tests --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
kennylam
added a commit
to kennylam/carbon-for-ibm-dotcom
that referenced
this issue
Jun 11, 2024
### Related Ticket(s) carbon-design-system#9567 ### Description This updates the React masthead logo URL to use `https`. ### Changelog **Changed** - React masthead logo URL changed to use `https` <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "test: e2e": Codesandbox examples and e2e integration tests --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
We are working on research.ibm.com, this is requested by our SEO specialist.
The href for the "IBM Logo" on the masthead has
HTTPprotocol:Http link in code
At the same time is under
useAlternateLogocondition the protocol set toHTTPS:Https link
The best would be if you would make the protocol configurable. It would be nice to have the ability to use protocol-relative URIs (
//www.ibm.com) when an empty protocol is used.Component(s) impacted
Browser
No response
Carbon for IBM.com version
v1.20.0
Severity
Severity 3 = The problem is visible or noticeable to users but does not impede the usability or functionality. Affects minor functionality, has a workaround.
Application/website
research.ibm.com
Package
@carbon/ibmdotcom-react
CodeSandbox example
https://codesandbox.io/s/github/carbon-design-system/carbon-for-ibm-dotcom/tree/main/packages/react/examples/codesandbox/components/Masthead
Steps to reproduce the issue (if applicable)
No response
Release date (if applicable)
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: