Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: cwc stacking tearsheets #11586

Merged
merged 24 commits into from
Feb 29, 2024
Merged

feat: cwc stacking tearsheets #11586

merged 24 commits into from
Feb 29, 2024

Conversation

lee-chase
Copy link
Member

Related Ticket(s)

Builds on #11545

Description

Adds the stacking feature to tearsheets. It also updates the version of @carbon/ibm-products-styles

Changelog

Changed

  • packages/carbon-web-components/package.json
  • packages/carbon-web-components/src/components/tearsheet/story-styles.scss
  • packages/carbon-web-components/src/components/tearsheet/tearsheet-story.ts
  • packages/carbon-web-components/src/components/tearsheet/tearsheet.scss
  • packages/carbon-web-components/src/components/tearsheet/tearsheet.ts
  • yarn.lock

lee-chase and others added 15 commits February 16, 2024 10:27
@lee-chase
chore: tearsheet wip
da7b3cc
@lee-chase
feat: add navigation
195448a
@lee-chase
feat: add influencer
d96b960
@lee-chase
Merge branch 'main' into cwc-tearsheet
bd1efa1
@lee-chase
Merge branch 'main' into cwc-tearsheet
bd43d0d
@lee-chase
feat: update to ai v2 styling
3202a62
@lee-chase
fix: header actions location
41344d3
@lee-chase
Merge branch 'main' into cwc-tearsheet
9432954
@lee-chase
Merge branch 'main' into cwc-tearsheet
9926d06
@lee-chase
Merge branch 'main' into cwc-tearsheet
da069c4
@lee-chase @ariellalgilmore
Update packages/carbon-web-components/src/components/side-panel/side-…
19591ff 
…panel.ts

Co-authored-by: Ariella Gilmore <[email protected]>
@lee-chase @ariellalgilmore
Update packages/carbon-web-components/src/components/tearsheet/tearsh…
ad6098c 
…eet.scss

Co-authored-by: Ariella Gilmore <[email protected]>
@lee-chase
fix: review updates
9635516
@lee-chase
fix: cds usage in tearsheet styles
dda5a89
@lee-chase
feat: add stacking ability to tearsheet
80dbdb5
@lee-chase lee-chase mentioned this pull request Feb 27, 2024
Merged
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 27, 2024 •
edited
Loading

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11586/index.html

Built with commit: 517d162870848613d62aa02bc56508491ff0e57a

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 27, 2024 •
edited
Loading

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11586/index.html

Built with commit: 517d162870848613d62aa02bc56508491ff0e57a

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 27, 2024 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11586/index.html

Built with commit: 517d162870848613d62aa02bc56508491ff0e57a

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 27, 2024 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11586/index.html

Built with commit: 517d162870848613d62aa02bc56508491ff0e57a

@lee-chase lee-chase marked this pull request as ready for review February 28, 2024 10:00
@lee-chase lee-chase requested a review from a team as a code owner February 28, 2024 10:00
@lee-chase lee-chase requested review from IgnacioBecerra and sangeethababu9223 and removed request for a team February 28, 2024 10:00
ariellalgilmore
ariellalgilmore reviewed Feb 28, 2024
View reviewed changes
Copy link
Member

@ariellalgilmore ariellalgilmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like need to update the yarn.lock file. the ci-checks are throwing errors

packages/carbon-web-components/src/components/tearsheet/tearsheet-story.ts Outdated Show resolved Hide resolved
ariellalgilmore
ariellalgilmore reviewed Feb 29, 2024
View reviewed changes
packages/carbon-web-components/src/components/tearsheet/tearsheet-story.ts Outdated
@@ -315,7 +315,10 @@ const slugs = {
const getSlug = (index) => {
switch (index) {
case 1:
return html`<cds-slug slot="slug" className="slug-container" size="xs">
return html`<cds-slug
className="slug-container"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small thing... should just be class in web components, but i don't think this is being used anyways

ariellalgilmore
ariellalgilmore approved these changes Feb 29, 2024
View reviewed changes
Copy link
Member

@ariellalgilmore ariellalgilmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ariellalgilmore ariellalgilmore added the Ready to merge Label for the pull requests that are ready to merge label Feb 29, 2024
@kodiakhq kodiakhq bot removed the Ready to merge Label for the pull requests that are ready to merge label Feb 29, 2024
@kodiakhq kodiakhq
Copy link
Contributor

kodiakhq bot commented Feb 29, 2024

This PR currently has a merge conflict. Please resolve this and then re-add the Ready to merge label.

@annawen1 annawen1 added the Ready to merge Label for the pull requests that are ready to merge label Feb 29, 2024
@ariellalgilmore ariellalgilmore merged commit 7a1842e into carbon-design-system:main Feb 29, 2024
4 of 8 checks passed
@annawen1
Copy link
Member

Hey there! This issue/pull request was referenced in recently released v2.5.0.

kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Mar 20, 2024
@lee-chase @ariellalgilmore
@kodiakhq @kennylam
feat: cwc stacking tearsheets (carbon-design-system#11586)
d6f13bb 
* chore: tearsheet wip

* feat: add navigation

* feat: add influencer

* feat: update to ai v2 styling

* fix: header actions location

* Merge branch 'main' into cwc-tearsheet

* Update packages/carbon-web-components/src/components/side-panel/side-panel.ts

Co-authored-by: Ariella Gilmore <[email protected]>

* Update packages/carbon-web-components/src/components/tearsheet/tearsheet.scss

Co-authored-by: Ariella Gilmore <[email protected]>

* fix: review updates

* fix: cds usage in tearsheet styles

* feat: add stacking ability to tearsheet

* chore: review remove slot="slug"

* fix: lock file

* fix: remove slug-container classname

---------

Co-authored-by: Ariella Gilmore <[email protected]>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Jun 11, 2024
@lee-chase @ariellalgilmore @kodiakhq
feat: cwc stacking tearsheets (carbon-design-system#11586)
32a2a7a 
* chore: tearsheet wip

* feat: add navigation

* feat: add influencer

* feat: update to ai v2 styling

* fix: header actions location

* Merge branch 'main' into cwc-tearsheet

* Update packages/carbon-web-components/src/components/side-panel/side-panel.ts

Co-authored-by: Ariella Gilmore <[email protected]>

* Update packages/carbon-web-components/src/components/tearsheet/tearsheet.scss

Co-authored-by: Ariella Gilmore <[email protected]>

* fix: review updates

* fix: cds usage in tearsheet styles

* feat: add stacking ability to tearsheet

* chore: review remove slot="slug"

* fix: lock file

* fix: remove slug-container classname

---------

Co-authored-by: Ariella Gilmore <[email protected]>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ariellalgilmore ariellalgilmore ariellalgilmore approved these changes

@IgnacioBecerra IgnacioBecerra Awaiting requested review from IgnacioBecerra IgnacioBecerra is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@sangeethababu9223 sangeethababu9223 Awaiting requested review from sangeethababu9223 sangeethababu9223 is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees
No one assigned
Labels
Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lee-chase @ibmdotcom-bot @annawen1 @ariellalgilmore