Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[carbon-web-components]: [datatable] search is not working using uppercase characters in query #11483

Closed
2 tasks done
fnicastri opened this issue Feb 2, 2024 · 0 comments · Fixed by #11493
Closed
2 tasks done

[carbon-web-components]: [datatable] search is not working using uppercase characters in query #11483

fnicastri opened this issue Feb 2, 2024 · 0 comments · Fixed by #11493
Assignees
@sangeethababu9223
Labels
bug Something isn't working dev Needs some dev work package: carbon web components

Comments

@fnicastri
Copy link

Description

Using upper case characters in search box return always zero results.
The comparison is done lowercasing the data from the table but not the query string.

codesandbox

Component(s) impacted

datatable

Browser

Chrome

Carbon for IBM.com version

2.2.0/latest

Severity

Severity 1 = The design is broken in a critical way that blocks users from completing tasks or damages the brand. Affects major functionality, no workaround.

Application/website

/

Package

@carbon/web-components

CodeSandbox example

https://codesandbox.io/p/sandbox/vigorous-rubin-6ndry9

Steps to reproduce the issue (if applicable)

No response

Release date (if applicable)

No response

Code of Conduct
@fnicastri fnicastri added bug Something isn't working dev Needs some dev work labels Feb 2, 2024
@kennylam kennylam moved this to Backlog in Carbon for IBM.com Feb 5, 2024
@sangeethababu9223 sangeethababu9223 self-assigned this Feb 6, 2024
@sangeethababu9223 sangeethababu9223 mentioned this issue Feb 6, 2024
Merged
@sangeethababu9223 sangeethababu9223 moved this from Backlog to Review in Carbon for IBM.com Feb 6, 2024
@kodiakhq kodiakhq bot closed this as completed in #11493 Feb 6, 2024
kodiakhq bot pushed a commit that referenced this issue Feb 6, 2024
@sangeethababu9223
fix(datatable): search not working with uppercase characters in query (…
7c92bfe 
…#11493)

### Related Ticket(s)

Closes #11483

### Description

Search is not working as expected with uppercase characters in query string.

### Changelog

**Changed**

- Updated the search logic to convert the query string as well as the main string to lowercase and then compare.

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
@github-project-automation github-project-automation bot moved this from Review to Done in Carbon for IBM.com Feb 6, 2024
kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this issue Mar 12, 2024
@sangeethababu9223 @kennylam
fix(datatable): search not working with uppercase characters in query (…
402ed43 
…carbon-design-system#11493)

### Related Ticket(s)

Closes carbon-design-system#11483

### Description

Search is not working as expected with uppercase characters in query string.

### Changelog

**Changed**

- Updated the search logic to convert the query string as well as the main string to lowercase and then compare.

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this issue Jun 11, 2024
@sangeethababu9223
fix(datatable): search not working with uppercase characters in query (…
cf6277b 
…carbon-design-system#11493)

### Related Ticket(s)

Closes carbon-design-system#11483

### Description

Search is not working as expected with uppercase characters in query string.

### Changelog

**Changed**

- Updated the search logic to convert the query string as well as the main string to lowercase and then compare.

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sangeethababu9223 sangeethababu9223

Labels
bug Something isn't working dev Needs some dev work package: carbon web components
Projects
Carbon for IBM.com
Archived in project
Milestone
No milestone
3 participants
@kennylam @fnicastri @sangeethababu9223