Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to filter inside a expandable fields #11179

Closed
1 of 2 tasks
Spielberg opened this issue Nov 30, 2023 · 0 comments · Fixed by #11438
Closed
1 of 2 tasks

Unable to filter inside a expandable fields #11179

Spielberg opened this issue Nov 30, 2023 · 0 comments · Fixed by #11438
Assignees
@sangeethababu9223
Labels
bug Something isn't working dev Needs some dev work package: carbon web components

Comments

@Spielberg
Copy link

Spielberg commented Nov 30, 2023 •
edited
Loading

Description

In a cds-table-expanded-row component, I have specific text that I want to be able to filter, but the filterRows function doesn't work for me because it only returns the content of the row and not the expanded text.

Component(s) impacted

<cds-table>
<cds-table-expanded-row></cds-table-expanded-row>
</cds-table>

Browser

Chrome

Carbon for IBM.com version

v2

Severity

Severity 1 = The design is broken in a critical way that blocks users from completing tasks or damages the brand. Affects major functionality, no workaround.

Application/website

private site

Package

@carbon/web-components

CodeSandbox example

https://codesandbox.io/p/devbox/priceless-cache-gtz44y?file=%2Findex.html

Steps to reproduce the issue (if applicable)

No response

Release date (if applicable)

No response

Code of Conduct
@Spielberg Spielberg added bug Something isn't working dev Needs some dev work labels Nov 30, 2023
@kennylam kennylam moved this to Backlog in Carbon for IBM.com Dec 4, 2023
@sangeethababu9223 sangeethababu9223 self-assigned this Jan 19, 2024
@sangeethababu9223 sangeethababu9223 moved this from Backlog to Doing in Carbon for IBM.com Jan 22, 2024
@sangeethababu9223 sangeethababu9223 mentioned this issue Jan 23, 2024
Merged
@sangeethababu9223 sangeethababu9223 moved this from Doing to Review in Carbon for IBM.com Jan 23, 2024
@kodiakhq kodiakhq bot closed this as completed in #11438 Jan 31, 2024
kodiakhq bot pushed a commit that referenced this issue Jan 31, 2024
@sangeethababu9223
fix(data table): filter issue in expansion table (#11438)
944a69a 
### Related Ticket(s)

Closes #11179

### Description

For expansion table, filtering doesn't include the content in the expanded row.


### Changelog

**Changed**

- Updated the filter function to check the expanded row.

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
@github-project-automation github-project-automation bot moved this from Review to Done in Carbon for IBM.com Jan 31, 2024
m4olivei pushed a commit to m4olivei/carbon-for-ibm-dotcom that referenced this issue Feb 1, 2024
@sangeethababu9223 @m4olivei
fix(data table): filter issue in expansion table (carbon-design-syste…
829a047 
…m#11438)

### Related Ticket(s)

Closes carbon-design-system#11179

### Description

For expansion table, filtering doesn't include the content in the expanded row.


### Changelog

**Changed**

- Updated the filter function to check the expanded row.

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this issue Jun 11, 2024
@sangeethababu9223
fix(data table): filter issue in expansion table (carbon-design-syste…
af9a526 
…m#11438)

### Related Ticket(s)

Closes carbon-design-system#11179

### Description

For expansion table, filtering doesn't include the content in the expanded row.


### Changelog

**Changed**

- Updated the filter function to check the expanded row.

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sangeethababu9223 sangeethababu9223

Labels
bug Something isn't working dev Needs some dev work package: carbon web components
Projects
Carbon for IBM.com
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(data table): filter issue in expansion table sangeethababu9223/carbon-for-ibm-dotcom
3 participants
@Spielberg @kennylam @sangeethababu9223