Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CDS Web Componet Progress Step problem with label attribute #11167

Closed
2 tasks done
alemscoder opened this issue Nov 26, 2023 · 0 comments · Fixed by #11430
Closed
2 tasks done

CDS Web Componet Progress Step problem with label attribute #11167

alemscoder opened this issue Nov 26, 2023 · 0 comments · Fixed by #11430
Assignees
@sangeethababu9223
Labels
bug Something isn't working dev Needs some dev work package: carbon web components

Comments

@alemscoder
Copy link

Description

The label text of the web component does not show when there are spaces or line breaks before the closing tag. I attach an example in Codepen

Component(s) impacted

Browser

Chrome

Carbon for IBM.com version

2.0.1

Severity

Severity 1 = The design is broken in a critical way that blocks users from completing tasks or damages the brand. Affects major functionality, no workaround.

Application/website

not ready yet

Package

@carbon/web-components

CodeSandbox example

https://codepen.io/alemscoder/pen/zYeayVV

Steps to reproduce the issue (if applicable)

No response

Release date (if applicable)

No response

Code of Conduct
@alemscoder alemscoder added bug Something isn't working dev Needs some dev work labels Nov 26, 2023
@kennylam kennylam moved this to Backlog in Carbon for IBM.com Nov 27, 2023
@sangeethababu9223 sangeethababu9223 self-assigned this Jan 18, 2024
@sangeethababu9223 sangeethababu9223 moved this from Backlog to Doing in Carbon for IBM.com Jan 19, 2024
@sangeethababu9223 sangeethababu9223 mentioned this issue Jan 22, 2024
Merged
@sangeethababu9223 sangeethababu9223 moved this from Doing to Review in Carbon for IBM.com Jan 22, 2024
@kodiakhq kodiakhq bot closed this as completed in #11430 Jan 22, 2024
kodiakhq bot pushed a commit that referenced this issue Jan 22, 2024
@sangeethababu9223
fix(progress-indicator): label attribute not showing when there is wh…
954ecf4 
…en there is white space before closing tag (#11430)

…ite space before closing

### Related Ticket(s)

Closes #11167

### Description

The label text of the web component does not show when there are spaces or line breaks before the closing tag.
There is an unnamed slot in the component, which replaces the `<p>` tag with the white space inside the component.

### Changelog

**Changed**

- Named the slot the to `label-text`.

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
@github-project-automation github-project-automation bot moved this from Review to Done in Carbon for IBM.com Jan 22, 2024
kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this issue Jun 11, 2024
@sangeethababu9223
fix(progress-indicator): label attribute not showing when there is wh…
f6cfa33 
…en there is white space before closing tag (carbon-design-system#11430)

…ite space before closing

### Related Ticket(s)

Closes carbon-design-system#11167

### Description

The label text of the web component does not show when there are spaces or line breaks before the closing tag.
There is an unnamed slot in the component, which replaces the `<p>` tag with the white space inside the component.

### Changelog

**Changed**

- Named the slot the to `label-text`.

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sangeethababu9223 sangeethababu9223

Labels
bug Something isn't working dev Needs some dev work package: carbon web components
Projects
Carbon for IBM.com
Archived in project
Milestone
No milestone
3 participants
@kennylam @sangeethababu9223 @alemscoder