Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Carbon for IBM.com and Angular #10885

Closed
2 tasks done
igaldino opened this issue Aug 25, 2023 · 1 comment · Fixed by #11069
Closed
2 tasks done

Upgrade Carbon for IBM.com and Angular #10885

igaldino opened this issue Aug 25, 2023 · 1 comment · Fixed by #11069
Assignees
@kennylam
Labels
bug Something isn't working dev Needs some dev work package: carbon web components

Comments

@igaldino
Copy link

Description

I'm running Angular 9 and Carbon for IBM.com web components v1.25.0.
I'm trying to upgrade them to fix vulnerabilities found in these components.
Another reason is that IBM CIO pipeline requires newer Angular versions.
I'm stuck, I can't migrate to a more recent Angular and Carbon for IBM.com web components versions.
When I try to migrate Carbon for IBM.com web components v1.26.0 I get the following errors:

ERROR in node_modules/@carbon/ibmdotcom-web-components/es/components/image/image.d.ts:329:16 - error TS1005: ')' expected.

329 } & ((abstract new (...args: any[]) => {
                   ~~~
node_modules/@carbon/ibmdotcom-web-components/es/components/image/image.d.ts:329:21 - error TS1109: Expression expected.

329 } & ((abstract new (...args: any[]) => {
                        ~~~
node_modules/@carbon/ibmdotcom-web-components/es/components/image/image.d.ts:329:34 - error TS1011: An element access expression should take an argument.

329 } & ((abstract new (...args: any[]) => {

If I try to upgrade to Angular 10, I get:

node_modules/@carbon/ibmdotcom-web-components/es/components/masthead/masthead-composite.d.ts:112:61 - error TS1005: ',' expected.

112     closest<K_3 extends keyof SVGElementTagNameMap>(selector: K_3): SVGElementTagNameMap[K_3] | null;
                                                                ~
node_modules/@carbon/ibmdotcom-web-components/es/components/masthead/masthead-composite.d.ts:112:67 - error TS1005: ';' expected.

112     closest<K_3 extends keyof SVGElementTagNameMap>(selector: K_3): SVGElementTagNameMap[K_3] | null;

Component(s) impacted

All Carbon for IBM.com web components.

Browser

Firefox

Carbon for IBM.com version

v1.25.0

Severity

Severity 1 = The design is broken in a critical way that blocks users from completing tasks or damages the brand. Affects major functionality, no workaround.

Application/website

https://w3east-limited-use.cpc.ibm.com/isc/esd/dswdown/home

Package

@carbon/ibmdotcom-web-components, @carbon/web-components

CodeSandbox example

https://github.com/igaldino/stackblitz-carbon-for-ibm-dotcom

Steps to reproduce the issue (if applicable)

No response

Release date (if applicable)

No response

Code of Conduct
@igaldino igaldino added bug Something isn't working dev Needs some dev work labels Aug 25, 2023
@kennylam kennylam moved this to Backlog in Carbon for IBM.com Sep 5, 2023
@igaldino
Copy link
Author

I've tested it with v1.37.0 and the issue is still happening.

@kennylam kennylam self-assigned this Oct 26, 2023
@kennylam kennylam moved this from Backlog to Doing in Carbon for IBM.com Oct 26, 2023
@kennylam kennylam mentioned this issue Oct 26, 2023
Merged
@kodiakhq kodiakhq bot closed this as completed in #11069 Oct 26, 2023
kodiakhq bot pushed a commit that referenced this issue Oct 26, 2023
@kennylam
fix(language-selector): remove internal decorator (#11069)
d61199d 
### Related Ticket(s)

Closes #10885 

### Description

Removes the `@internal` decorator from `language-selector` which was preventing output to the `.d.ts`. Also removes unneeded code from `bx-input`.

### Changelog

**New**

- {{new thing}}

**Changed**

- {{changed thing}}

**Removed**

- `@internal` decorator
- unused getter/setter from `bx-input`

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
@github-project-automation github-project-automation bot moved this from Doing to Done in Carbon for IBM.com Oct 26, 2023
kennylam added a commit that referenced this issue Oct 28, 2023
@kennylam
fix(language-selector): remove internal decorator (#11069)
5525ab9 
### Related Ticket(s)

Closes #10885 

### Description

Removes the `@internal` decorator from `language-selector` which was preventing output to the `.d.ts`. Also removes unneeded code from `bx-input`.

### Changelog

**New**

- {{new thing}}

**Changed**

- {{changed thing}}

**Removed**

- `@internal` decorator
- unused getter/setter from `bx-input`

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
kennylam added a commit to kennylam/carbon-for-ibm-dotcom that referenced this issue Dec 4, 2023
@kennylam
fix(language-selector): remove internal decorator (carbon-design-syst…
2c601c5 
…em#11069)

### Related Ticket(s)

Closes carbon-design-system#10885 

### Description

Removes the `@internal` decorator from `language-selector` which was preventing output to the `.d.ts`. Also removes unneeded code from `bx-input`.

### Changelog

**New**

- {{new thing}}

**Changed**

- {{changed thing}}

**Removed**

- `@internal` decorator
- unused getter/setter from `bx-input`

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
kennylam added a commit to kennylam/carbon-for-ibm-dotcom that referenced this issue Jun 11, 2024
@kennylam
fix(language-selector): remove internal decorator (carbon-design-syst…
edfaa29 
…em#11069)

### Related Ticket(s)

Closes carbon-design-system#10885 

### Description

Removes the `@internal` decorator from `language-selector` which was preventing output to the `.d.ts`. Also removes unneeded code from `bx-input`.

### Changelog

**New**

- {{new thing}}

**Changed**

- {{changed thing}}

**Removed**

- `@internal` decorator
- unused getter/setter from `bx-input`

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kennylam kennylam

Labels
bug Something isn't working dev Needs some dev work package: carbon web components
Projects
Carbon for IBM.com
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(language-selector): remove internal decorator kennylam/carbon-for-ibm-dotcom
2 participants
@kennylam @igaldino