Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pricing-table]: combine checkmark with copy #10499

Closed
2 tasks done
andy-blum opened this issue May 23, 2023 · 0 comments
Closed
2 tasks done

[pricing-table]: combine checkmark with copy #10499

andy-blum opened this issue May 23, 2023 · 0 comments
Assignees
Labels
adopter: AEM used when component or pattern will be used by this adopter Feature request A new adopter requested feature owner: AEM owner: Innovation Team used when the engineering work will be done by Hybrid Cloud with DDS engineers as consultants package: web components Work necessary for the IBM.com Library web components package

Comments

@andy-blum
Copy link
Contributor

The problem

Request to allow for checkmark to be combined with text in table cell. Currently it's only possible to have an icon or text.

The solution

screenshot_2023-04-25_at_2 09 27_pm

Application/website

AEM

Business priority

Medium Priority = upcoming release but is not pressing

What time frame would this ideally be needed by (if applicable)

No response

Examples

No response

Code of Conduct

@andy-blum andy-blum added Feature request A new adopter requested feature package: web components Work necessary for the IBM.com Library web components package adopter: AEM used when component or pattern will be used by this adopter owner: AEM owner: Innovation Team used when the engineering work will be done by Hybrid Cloud with DDS engineers as consultants labels May 23, 2023
@m4olivei m4olivei self-assigned this Jun 5, 2023
@kennylam kennylam moved this to Backlog in Carbon for IBM.com Jun 21, 2023
kodiakhq bot pushed a commit that referenced this issue Jun 23, 2023
### Related Ticket(s)

https://jsw.ibm.com/browse/ADCMS-3264
#10499

### Description

Allows a user of the pricing table to opt in to their slotted text to be shown alongsizde an icon within a pricing table cell.

### Changelog

**New**

- `dds-pricing-table-cell` now supports an `icon-text` attribute that when set will signal slotted text nodes to display next to the selected icon. If the icon attribute is not set, no change.

### Testing

- [ ] Search for "Pricing Table" in Storybook Story
- [ ] Check the "Show text with icon" checkbox
- [ ] Verify that the slotted text displays next to the icon.
m4olivei added a commit to m4olivei/carbon-for-ibm-dotcom that referenced this issue Jun 23, 2023
…ign-system#10550)

### Related Ticket(s)

https://jsw.ibm.com/browse/ADCMS-3264
carbon-design-system#10499

### Description

Allows a user of the pricing table to opt in to their slotted text to be shown alongsizde an icon within a pricing table cell.

### Changelog

**New**

- `dds-pricing-table-cell` now supports an `icon-text` attribute that when set will signal slotted text nodes to display next to the selected icon. If the icon attribute is not set, no change.

### Testing

- [ ] Search for "Pricing Table" in Storybook Story
- [ ] Check the "Show text with icon" checkbox
- [ ] Verify that the slotted text displays next to the icon.
IgnacioBecerra pushed a commit that referenced this issue Jun 23, 2023
…10595)

### Related Ticket(s)

https://jsw.ibm.com/browse/ADCMS-3264
#10499

### Description

Allows a user of the pricing table to opt in to their slotted text to be shown alongsizde an icon within a pricing table cell.

### Changelog

**New**

- `dds-pricing-table-cell` now supports an `icon-text` attribute that when set will signal slotted text nodes to display next to the selected icon. If the icon attribute is not set, no change.

### Testing

- [ ] Search for "Pricing Table" in Storybook Story
- [ ] Check the "Show text with icon" checkbox
- [ ] Verify that the slotted text displays next to the icon.
@github-project-automation github-project-automation bot moved this from Backlog to Done in Carbon for IBM.com Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adopter: AEM used when component or pattern will be used by this adopter Feature request A new adopter requested feature owner: AEM owner: Innovation Team used when the engineering work will be done by Hybrid Cloud with DDS engineers as consultants package: web components Work necessary for the IBM.com Library web components package
Projects
Archived in project
Development

No branches or pull requests

2 participants