Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagate name and required from TileGroup. #973

Closed
wants to merge 2 commits into from
Closed

Propagate name and required from TileGroup. #973

wants to merge 2 commits into from

Conversation

brunnerh
Copy link
Contributor

@brunnerh brunnerh commented Jan 5, 2022

Remove name from RadioTile.

Fixes #972.

Probably causes conflicts with pull request #971

@brunnerh
Propagate name and required from TileGroup.
7579028 
Remove `name` from `RadioTile`.
@metonym metonym added the blocked by upstream Requires a fix upstream label Jan 8, 2022
theetrain
theetrain reviewed Dec 11, 2022
View reviewed changes
Copy link
Collaborator

@theetrain theetrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, and overall these changes work well. 👍

All that remains are some documentation updates. I do not see any conflicts upstream nor elsewhere. cc @metonym

@metonym metonym added breaking changes and removed blocked by upstream Requires a fix upstream labels Dec 11, 2022
@brunnerh brunnerh mentioned this pull request Oct 3, 2023
Merged
@brunnerh
Copy link
Contributor Author

brunnerh commented Oct 3, 2023

Obsoleted by:

@brunnerh brunnerh closed this Oct 3, 2023
@brunnerh brunnerh deleted the tile-required branch October 3, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theetrain theetrain theetrain left review comments

Assignees
No one assigned
Labels
breaking changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Native RadioTile required validation not supported
3 participants
@brunnerh @theetrain @metonym