fix(Select): match experimental spec #2030
Conversation
|
Deploy preview for carbon-components-react ready! Built with commit 6503cf2 https://deploy-preview-2030--carbon-components-react.netlify.com |
src/components/Select/Select.js
Outdated
| <label htmlFor={id} className={labelClasses}> | ||
| {labelText} | ||
| </label> | ||
| {componentsX && !inline && helper} |
There was a problem hiding this comment.
The markup change seems to affect v9. Could you please double-check v9 is not broken?
There was a problem hiding this comment.
it should be fixed now @asudoh
There was a problem hiding this comment.
OK thank you for adding that back! Actually v9 topic came up as the helper used to be next icon whereas it's next to <label> in this PR. Wanted to make sure such move-around doesn't negatively affecting v9. Thanks!
There was a problem hiding this comment.
@emyarod You are right, I may have been seeing a stale commit, my apologies!
emyarod
force-pushed
the
2026-match-select-to-experimental-spec
branch
2 times, most recently
from
72d0ab5 to
9e966e9
Compare
emyarod
added
status: WIP 👩💻
and removed
status: one more review 👀
status: ready for review 👀
labels
|
currently in the middle of incorporating changes from carbon-design-system/carbon#2114 to add legacy support for inline helper text @tw15egan, will likely need another review in a bit |
|
Okay, just ping me when re-review is needed |
|
@tw15egan carbon-design-system/carbon#2135 is now ready for review |
emyarod
force-pushed
the
2026-match-select-to-experimental-spec
branch
from
9e966e9 to
25c9e73
Compare
|
Oh ok the knob was only changing the field but I guess the labels are controlled by a different knob? |
emyarod
force-pushed
the
2026-match-select-to-experimental-spec
branch
from
7d47ff7 to
6503cf2
Compare
|
@aagonzales can you double check again? I was still moving newly added changes from vanilla over when you reviewed, but disabling the component should also be changing label and helper text |
|
@emyarod yup! The knob is changing the label and helper text now so its good! |
|
🎉 This PR is included in version 6.109.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Closes IBM/carbon-components-react#2026
Closes https://github.com/IBM/carbon-components-react/issues/2037
This PR incorporates feedback from the February 2019 select component audit
Depends on carbon-design-system/carbon#2114 and carbon-design-system/carbon#2135