Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set definedZoomBarData to zoom bar data #909

Merged
merged 1 commit into from
Jan 7, 2021
Merged

fix: set definedZoomBarData to zoom bar data #909

merged 1 commit into from
Jan 7, 2021

Conversation

hlyang397
Copy link
Contributor

Updates

  • when set zoom bar data, use defined zoom bar data if exists.
  • Without this fix, zoom bar will always use chart data instead of zoom bar data when setData is called.

Demo screenshot or recording

No change in demos.
It only has impact when zoom bar data is updated in run time.

Review checklist (for reviewers only)

  • Demos all features
  • Documented/annotated
  • Matches UI/UX specs
  • Meets the code style guide
  • Accessible
  • Mobile first (responsive)
  • RTL support (bidirectional text)
  • Performant (limited bloat)

@hlyang397 hlyang397 requested review from zvonimirfras and removed request for a team December 14, 2020 08:53
@theiliad theiliad added the type: bug 🐛 Something isn't working label Jan 6, 2021
@theiliad theiliad requested a review from sophiiae January 6, 2021 15:39
@theiliad theiliad merged commit d446e47 into carbon-design-system:master Jan 7, 2021
@theiliad theiliad deleted the set-defined-zoomBarData branch January 8, 2021 17:21
theiliad pushed a commit to theiliad/carbon-charts that referenced this pull request May 17, 2021
@hlyang397 @carbon-bot
fix: set definedZoomBarData to zoom bar data (carbon-design-system#909)
99b0b16 
Co-authored-by: carbon-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theiliad theiliad theiliad approved these changes

@cal-smith cal-smith cal-smith approved these changes

@natashadecoste natashadecoste Awaiting requested review from natashadecoste

@zvonimirfras zvonimirfras Awaiting requested review from zvonimirfras

@sophiiae sophiiae Awaiting requested review from sophiiae

Assignees
No one assigned
Labels
type: bug 🐛 Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hlyang397 @cal-smith @theiliad @carbon-bot