Allow toolbar button background to receive hover state change #884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- allow hover event to be triggered
hlyang397
requested review from
natashadecoste,
theiliad and
a team
as code owners
hlyang397
changed the title
theiliad
requested changes
Nov 12, 2020
We had all these zoom bar demos before we got toolbar PR merged, so that is expected. |
zvonimirfras
approved these changes
Nov 16, 2020
theiliad
approved these changes
Nov 16, 2020
JennChao
added a commit
to JennChao/carbon-charts
that referenced
this pull request
Nov 17, 2020
…on-charts into sparkline-with-scale-color-option * 'master' of https://github.com/carbon-design-system/carbon-charts: (24 commits) v0.41.4 Merge pull request carbon-design-system#882 from theiliad/demo-treemap-fix docs(core): add theme & API tutorials to storybook (carbon-design-system#883) v0.41.3 Merge pull request carbon-design-system#880 from sophiiae/fix-import-colors fix(core): use fill:transparent for toolbar controls (carbon-design-system#884) v0.41.2 fix(core): tooltips should hide when mouseout is triggered on the chart holder (carbon-design-system#887) fix(core): sanitize user provided axis domains add treemap to the component status table v0.41.1 Merge pull request carbon-design-system#719 from theiliad/tree-map fix(core): correct axis title paddings in y-axes (carbon-design-system#873) v0.41.0 fix: use fill:none to allow transparent toolbar control background (carbon-design-system#858) feat(core): add alignment options for gauge charts (carbon-design-system#877) v0.40.14 fix(core): replace import to lodash with lodash-es fix(core): only set zoombar data and sanitize date values if a cartesian time-series chart v0.40.13 ...
theiliad
pushed a commit
to theiliad/carbon-charts
that referenced
this pull request
May 17, 2021
…ystem#884) - allow hover event to be triggered
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When mouseover to toolbar button background (not the icon), the toolbar button background won't change the color.
It's my bad that I didn't fix it 100% correctly in #858.
Updates
Demo screenshot or recording
Before fix:
After fix:
Review checklist (for reviewers only)