Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix the defect of label tooltip not showing when using custom tooltip #787

Merged
merged 3 commits into from
Sep 10, 2020
Merged

fix the defect of label tooltip not showing when using custom tooltip #787

merged 3 commits into from
Sep 10, 2020

Conversation

linhenry0417
Copy link
Contributor

@linhenry0417 linhenry0417 commented Sep 3, 2020 •
edited
Loading

The tooltip for axis labels is not rendering when a custom tooltip HTML is provided in options.

When the user provides a custom tooltip HTML for the chart, the tooltip to show the full truncated text in the vertical axis is not rendering:
This PR is to fix this.
imagefffff

@linhenry0417 linhenry0417 requested review from sophiiae and removed request for a team September 3, 2020 18:19
@linhenry0417
Copy link
Contributor Author

@theiliad @sophiiae This should be a quick fix to the issue described above. Thanks.

@theiliad theiliad added the type: bug 🐛 Something isn't working label Sep 10, 2020
@theiliad theiliad merged commit 0af084c into carbon-design-system:master Sep 10, 2020
JennChao added a commit to JennChao/carbon-charts that referenced this pull request Sep 11, 2020
@JennChao
Merge branch 'master' of https://github.com/JennChao/carbon-charts in…
65a83e0 
…to ruler-option

* 'master' of https://github.com/JennChao/carbon-charts:
  v0.36.4
  Merge pull request carbon-design-system#761 from JennChao/sparkline
  Merge pull request carbon-design-system#793 from hlyang397/update-initial-zoom-domain
  fix the defect of label tooltip not showing when using custom tooltip (carbon-design-system#787)
  v0.36.3
  Merge pull request carbon-design-system#785 from sophiiae/skeleton-with-data
JennChao added a commit to JennChao/carbon-charts that referenced this pull request Sep 11, 2020
@JennChao
Merge branch 'master' of https://github.com/JennChao/carbon-charts in…
e26af21 
…to scatter-option

* 'master' of https://github.com/JennChao/carbon-charts:
  v0.36.4
  Merge pull request carbon-design-system#761 from JennChao/sparkline
  Merge pull request carbon-design-system#793 from hlyang397/update-initial-zoom-domain
  fix the defect of label tooltip not showing when using custom tooltip (carbon-design-system#787)
  v0.36.3
  Merge pull request carbon-design-system#785 from sophiiae/skeleton-with-data
JennChao added a commit to JennChao/carbon-charts that referenced this pull request Sep 11, 2020
@JennChao
Merge branch 'master' of https://github.com/JennChao/carbon-charts in…
ac65ec2 
…to linearGradient

* 'master' of https://github.com/JennChao/carbon-charts:
  v0.36.4
  Merge pull request carbon-design-system#761 from JennChao/sparkline
  Merge pull request carbon-design-system#793 from hlyang397/update-initial-zoom-domain
  fix the defect of label tooltip not showing when using custom tooltip (carbon-design-system#787)
  v0.36.3
  Merge pull request carbon-design-system#785 from sophiiae/skeleton-with-data
JennChao added a commit to JennChao/carbon-charts that referenced this pull request Sep 11, 2020
@JennChao
Merge branch 'master' of https://github.com/JennChao/carbon-charts in…
fb9d8e9 
…to axis-option

* 'master' of https://github.com/JennChao/carbon-charts:
  v0.36.4
  Merge pull request carbon-design-system#761 from JennChao/sparkline
  Merge pull request carbon-design-system#793 from hlyang397/update-initial-zoom-domain
  fix the defect of label tooltip not showing when using custom tooltip (carbon-design-system#787)
  v0.36.3
  Merge pull request carbon-design-system#785 from sophiiae/skeleton-with-data
JennChao added a commit to JennChao/carbon-charts that referenced this pull request Sep 15, 2020
@JennChao
Merge branch 'master' of https://github.com/JennChao/carbon-charts in…
b00aad9 
…to tooltip-option

* 'master' of https://github.com/JennChao/carbon-charts:
  v0.37.1
  Merge pull request carbon-design-system#800 from metonym/fix-svelte-base-chart
  v0.37.0
  Merge pull request carbon-design-system#780 from natashadecoste/fix-meter-max-val
  feat: enable or disable scatter dot on charts except scatter chart (carbon-design-system#769)
  feat: create options for tick rotation (carbon-design-system#770)
  v0.36.4
  Merge pull request carbon-design-system#761 from JennChao/sparkline
  Merge pull request carbon-design-system#793 from hlyang397/update-initial-zoom-domain
  fix the defect of label tooltip not showing when using custom tooltip (carbon-design-system#787)
  v0.36.3
  Merge pull request carbon-design-system#785 from sophiiae/skeleton-with-data
theiliad pushed a commit to theiliad/carbon-charts that referenced this pull request May 17, 2021
@linhenry0417
fix the defect of label tooltip not showing when using custom tooltip (…
020ebaa 
…carbon-design-system#787)

Co-authored-by: linhenry0417 <[email protected]>
Co-authored-by: Fei Z <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sophiiae sophiiae sophiiae approved these changes

@theiliad theiliad theiliad approved these changes

@natashadecoste natashadecoste natashadecoste approved these changes

Assignees
No one assigned
Labels
type: bug 🐛 Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@linhenry0417 @natashadecoste @theiliad @sophiiae