Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Colors, themes & more design updates #261

Merged
merged 17 commits into from
May 9, 2019

Conversation

theiliad
Copy link
Member

@theiliad theiliad commented Apr 29, 2019

Updates

  • Add a color service to provide the new color palette
  • Add theme utilities, and default themes (Only high contrast currently)
  • Pie & donut sizing and spacing between slices

#246, #252, #254, #255

Closes #243

@netlify
Copy link

netlify bot commented Apr 29, 2019

Deploy preview for carbon-charts ready!

Built with commit c32b6da

https://deploy-preview-261--carbon-charts.netlify.com

@cal-smith
Copy link
Contributor

Looking good 🎉 I'll close my draft since you've got all the high points covered

@theiliad
Copy link
Member Author

theiliad commented Apr 30, 2019

Looking good 🎉 I'll close my draft since you've got all the high points covered

Cool. We should find a way to collab on PRs, since I could've expanded on yours

@shixiedesign
Copy link

Question, so in Carbon we do visual reviews in the PR thread. This thread might get really long because all the charts updates are in one PR. Is there a different place you guys do visual reviews before merge? Or should we split this PR into a few parts so we can merge the charts one by one as soon as it is ready?

@theiliad
Copy link
Member Author

theiliad commented May 6, 2019

@shixiedesign This PR will mostly focus on some of the obvious or immediate changes we're going to merge (once colors are approved we will probably go ahead an merge this, then open up separate PRs for the nitty gritty of the rest of the component related updates)

Therefore, you're welcome to share your review here 🙂

Copy link

@shixiedesign shixiedesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Visual feedback on the color themes:

  • [Theme 1] all looks good except 1 color, Purple 80 should be Purple 30. My mistake in the spec image!

  • [Theme 2] please use below color progression for theme 2
    image

  • [Theme 3] is it possible to implement the dark theme? For light ui, theme 1 & 2 are sufficient for the time being I think. Unless you know more use cases. For dark ui, let's use this color progression:
    image

@theiliad
Copy link
Member Author

theiliad commented May 7, 2019

@shixiedesign Added all 3. For [Theme 2] that you sent, I added another variation teal Teal 70 that I was hoping you can review as well.

Here are the themes:
[Theme 1] => https://deploy-preview-261--carbon-charts.netlify.com/?experimental=true&theme=1
[Theme 2] => https://deploy-preview-261--carbon-charts.netlify.com/?experimental=true&theme=2
[Theme 2 + teal 70] => https://deploy-preview-261--carbon-charts.netlify.com/?experimental=true&theme=3
[Theme 3 (dark)] => https://deploy-preview-261--carbon-charts.netlify.com/?experimental=true&theme=4

Copy link

@shixiedesign shixiedesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Theme 1 & 3 looks good to go 🎉 🎉 🎉
Theme 2, I see why you are proposing Teal 70. I agree it's better too. But to maximize the rage of light and dark, let's use Teal 70 but darken the last color Cyan to Cyan 80. So this sequence:
image
Lemme know if you agree.

@theiliad theiliad marked this pull request as ready for review May 8, 2019 06:26
cal-smith
cal-smith previously approved these changes May 8, 2019
Copy link
Contributor

@cal-smith cal-smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM code wise 👍

@jeoffw
Copy link

jeoffw commented May 8, 2019

Can we add a Charts page to the main site (possibly linking to this site) so this is actually discoverable?

@zvonimirfras
Copy link
Member

@jeoffw yes please 😃

shixiedesign
shixiedesign previously approved these changes May 8, 2019
Copy link

@shixiedesign shixiedesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks!

@theiliad theiliad dismissed stale reviews from shixiedesign and cal-smith via 9f6fde8 May 9, 2019 06:55
@theiliad
Copy link
Member Author

theiliad commented May 9, 2019

@zvonimirfras @cal-smith
My final commit in this PR (no design changes @shixiedesign).

I changed the export themes to colorPalettes because I think the word theme can be interpreted as more than what this PR does.

We can explore the possibility of "themes" at some point, but I'd like to call the newly added service color palettes.

Feel free to merge if there are no objections 💯

@theiliad theiliad changed the title Colors, themes & more design updates feat(core): Colors, themes & more design updates May 9, 2019
Copy link
Contributor

@cal-smith cal-smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, themes are definitely a larger topic than just the colours ... Everything looks good to me 👍

@cal-smith cal-smith merged commit b0b9070 into carbon-design-system:master May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update palettes to new colors
5 participants