Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(table): fixed table proptypes and single select radio button issue #3832

Conversation

abpaul1993
Copy link
Collaborator

Closes #
https://jsw.ibm.com/browse/GRAPHITE-69162
Summary

  1. Fixing thrown: "Warning: Failed prop type: Invalid prop currentColumnWidths.wonum.width of type string supplied to ForwardRef, expected number. issue
  2. Considering single select radio button width while calculating % of column width
  • summary_here

Change List (commits, features, bugs, etc)

  • items_here

Acceptance Test (how to verify the PR)

  • tests here

Regression Test (how to make sure this PR doesn't break old functionality)

  • tests here

Things to look for during review

  • Make sure all references to iot or bx class prefix is using the prefix variable
  • (React) All major areas have a data-testid attribute. New test ids should have test written to ensure they are not changed or removed.
  • UI should be checked in RTL mode to ensure the proper handling of layout and text.
  • All strings should be translatable.
  • The code should pass a11y scans (The storybook a11y knob should show no violations). New components should have a11y test written.
  • Unit test should be written and should have a coverage of 90% or higher in all areas.
  • All components should be passing visual regression test. For new styles or components either a visual regression test should be written for all permutations or the base image updated.
  • Changes or new components should either write new or update existing documentation.
  • PR should link and close out an existing issue

@netlify
Copy link

netlify bot commented Oct 27, 2023

Deploy Preview for carbon-addons-iot-react ready!

Name Link
🔨 Latest commit c7f7d7f
🔍 Latest deploy log https://app.netlify.com/sites/carbon-addons-iot-react/deploys/653b99b33cdbf900087ae010
😎 Deploy Preview https://deploy-preview-3832--carbon-addons-iot-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sls-ca sls-ca merged commit 01a685d into next Oct 31, 2023
27 checks passed
@sls-ca sls-ca deleted the fix-GRAPHITE-69162-single-select-radiobutton-width-consideration-and-proptypes-issue-fix branch October 31, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants