Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ChartCards): translate group and total tooltip labels #1913

Merged
merged 10 commits into from
Jan 8, 2021

Conversation

sstone2423
Copy link
Contributor

@sstone2423 sstone2423 commented Jan 5, 2021

Closes #1912

Summary

Acceptance Test (how to verify the PR)

  • Start server locally and add the above i18n props to each card and see that the string is being translated correctly. Note: 'Total' is only shown in stacked bar charts when you hover over the total bar axis

@netlify
Copy link

netlify bot commented Jan 5, 2021

✔️ Deploy preview for carbon-addons-iot-react ready!

🔨 Explore the source changes: 096951b

🔍 Inspect the deploy logs: https://app.netlify.com/sites/carbon-addons-iot-react/deploys/5ff79f3b5ad0420007eb218e

😎 Browse the preview: https://deploy-preview-1913--carbon-addons-iot-react.netlify.app

@sstone2423
Copy link
Contributor Author

sstone2423 commented Jan 6, 2021

I'm not sure why, but I'm getting this console error which is causing PieChartCard's color tests to fail when carbon charts is updated

    console.error
      Missing CSS styles for Carbon Charts. Please read the Carbon Charts getting started guide.

      at node_modules/@carbon/charts/bundle.js:15:146057
      at Timeout.task [as _onTimeout] (node_modules/jsdom/lib/jsdom/browser/Window.js:391:19)

Copy link
Contributor

@scottdickerson scottdickerson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yarn.lock Outdated Show resolved Hide resolved
@kodiakhq kodiakhq bot merged commit 0d9731e into next Jan 8, 2021
@kodiakhq kodiakhq bot deleted the chart-translate branch January 8, 2021 21:05
@tay1orjones
Copy link
Member

🎉 This PR is included in version 2.142.1-next.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ChartCards] tooltip Group and Total labels are not translated
3 participants