-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ChartCards): translate group and total tooltip labels #1913
Conversation
✔️ Deploy preview for carbon-addons-iot-react ready! 🔨 Explore the source changes: 096951b 🔍 Inspect the deploy logs: https://app.netlify.com/sites/carbon-addons-iot-react/deploys/5ff79f3b5ad0420007eb218e 😎 Browse the preview: https://deploy-preview-1913--carbon-addons-iot-react.netlify.app |
I'm not sure why, but I'm getting this console error which is causing PieChartCard's color tests to fail when carbon charts is updated
|
…bon-addons-iot-react into chart-translate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🎉 This PR is included in version 2.142.1-next.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Closes #1912
Summary
tooltipGroupLabel
andtooltipTotalLabel
to BarChartCardtooltipGroupLabel
to TimeSeriesCard (doesn't use Total)Acceptance Test (how to verify the PR)