Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cardEditor): the showLegend was in the incorrect place for TimeSeriesCards #1833

Merged
merged 3 commits into from
Nov 30, 2020

Conversation

scottdickerson
Copy link
Contributor

@scottdickerson scottdickerson commented Nov 24, 2020

Closes #https://github.ibm.com/wiotp/monitoring-dashboard/issues/1659

Summary

  • Need to move the showLegend prop down to the actual content section of the TimeSeriesCard

Change List (commits, features, bugs, etc)

Acceptance Test (how to verify the PR)

@netlify
Copy link

netlify bot commented Nov 25, 2020

Deploy preview for carbon-addons-iot-react ready!

Built with commit f5b8945

https://deploy-preview-1833--carbon-addons-iot-react.netlify.app

@netlify
Copy link

netlify bot commented Nov 25, 2020

Deploy preview for carbon-addons-iot-react ready!

Built with commit fadb0ba

https://deploy-preview-1833--carbon-addons-iot-react.netlify.app

Copy link
Contributor

@JoelArmendariz JoelArmendariz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kodiakhq kodiakhq bot merged commit eb2944d into next Nov 30, 2020
@kodiakhq kodiakhq bot deleted the fix-cardeditor-showlegend branch November 30, 2020 15:32
@tay1orjones
Copy link
Member

🎉 This PR is included in version 2.141.0-next.29 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tay1orjones
Copy link
Member

🎉 This PR is included in version 2.141.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants