Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ComposedModal] Header object expects string as title value #1471

Closed
hectordavis opened this issue Aug 6, 2020 · 1 comment · Fixed by #1472
Closed

[ComposedModal] Header object expects string as title value #1471

hectordavis opened this issue Aug 6, 2020 · 1 comment · Fixed by #1472
Assignees
@cgirani
Labels
released type: bug 🐛

Comments

@hectordavis
Copy link
Collaborator

hectordavis commented Aug 6, 2020 •
edited by cgirani
Loading

Description:

ComposedModal header object expects a string as a value to the title key. It should accept node instead to allow more customization and prevent a warning in the console.

image
cgirani added a commit that referenced this issue Aug 6, 2020
@cgirani
fix(modal): prop types support to node #1471
6226ef9
@cgirani cgirani mentioned this issue Aug 6, 2020
Merged
tay1orjones added a commit that referenced this issue Aug 6, 2020
@tay1orjones
Merge pull request #1472 from carbon-design-system/1471-modal-proptype
458ab90 
fix(modal): prop types support to node #1471
@tay1orjones
Copy link
Member

🎉 This issue has been resolved in version 2.106.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cgirani cgirani

Labels
released type: bug 🐛
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(modal): prop types support to node #1471 carbon-design-system/carbon-addons-iot-react
3 participants
@tay1orjones @hectordavis @cgirani