Skip to content

Commit

Permalink
fix(dashboardeditorheader): remove isLoading prop as it will never re…
Browse files Browse the repository at this point in the history
…ach the header
  • Loading branch information
Stephen Stone committed Nov 10, 2020
1 parent 0f34ba3 commit fdff996
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 5 deletions.
1 change: 0 additions & 1 deletion src/components/DashboardEditor/DashboardEditor.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,6 @@ const DashboardEditor = ({
selectedBreakpointIndex={selectedBreakpointIndex}
setSelectedBreakpointIndex={setSelectedBreakpointIndex}
breakpointSwitcher={breakpointSwitcher}
isLoading={isLoading}
/>
)}
{notification}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,6 @@ const propTypes = {
enabled: PropTypes.bool,
allowedBreakpoints: PropTypes.arrayOf(PropTypes.string),
}),
/** optional loading prop to render the PageTitleBar loading state */
isLoading: PropTypes.bool,
};

const defaultProps = {
Expand Down Expand Up @@ -119,7 +117,6 @@ const DashboardEditorHeader = ({
selectedBreakpointIndex,
setSelectedBreakpointIndex,
breakpointSwitcher,
isLoading,
}) => {
const mergedI18n = { ...defaultProps.i18n, i18n };
const baseClassName = `${iotPrefix}--dashboard-editor-header`;
Expand Down Expand Up @@ -227,7 +224,6 @@ const DashboardEditorHeader = ({
title={title}
editable={!!onEditTitle}
onEdit={onEditTitle}
isLoading={isLoading}
i18n={{ editIconDescription: mergedI18n.headerEditTitleButton }}
/>
);
Expand Down

0 comments on commit fdff996

Please sign in to comment.