fix(dashboardeditor): support clearing the image and changing

carbon-design-system · Dec 8, 2020 · 2cc309b · 2cc309b
1 parent 948469b
commit 2cc309b
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 5 deletions.
diff --git a/...nts/CardEditor/CardEditForm/CardEditFormItems/ImageCardFormItems/ImageCardFormContent.jsx b/...nts/CardEditor/CardEditForm/CardEditFormItems/ImageCardFormItems/ImageCardFormContent.jsx
@@ -69,7 +69,13 @@ const ImageCardFormItems = ({ cardConfig, i18n, onChange }) => {
               onClick={() =>
                 // close means clear the image info out of the JSON
                 onChange(
-                  omit(cardConfig, 'content.id', 'content.src', 'content.alt')
+                  omit(
+                    cardConfig,
+                    'content.id',
+                    'content.src',
+                    'content.alt',
+                    'content.imgState'
+                  )
                 )
               }
             />

diff --git a/src/components/DashboardEditor/DashboardEditor.jsx b/src/components/DashboardEditor/DashboardEditor.jsx
@@ -331,10 +331,12 @@ const DashboardEditor = ({
       cardConfig.content.imgState === 'new' &&
       !imagesToUpload.some((image) => image.id === cardConfig.content.id)
     ) {
-      setImagesToUpload((prevImagesToUpload) => [
-        ...prevImagesToUpload,
-        { id: cardConfig.content.id, src: cardConfig.content.src },
-      ]);
+      if (cardConfig.content.id && cardConfig.content.src) {
+        setImagesToUpload((prevImagesToUpload) => [
+          ...prevImagesToUpload,
+          { id: cardConfig.content.id, src: cardConfig.content.src },
+        ]);
+      }
     }
 
     // TODO: this is really inefficient