fix(hierarchylist): change defaultselectedid onselect behavior

#1866
carbon-design-system · Dec 7, 2020 · 1a75985 · 1a75985
1 parent fb9b0f2
commit 1a75985
Showing 1 changed file with 12 additions and 10 deletions.
diff --git a/src/components/List/HierarchyList/HierarchyList.jsx b/src/components/List/HierarchyList/HierarchyList.jsx
@@ -220,23 +220,25 @@ const HierarchyList = ({
     [defaultSelectedId]
   );
 
-  const handleSelect = (id, parentId = null) => {
+  const setSelected = (id, parentId = null) => {
     if (editingStyle) {
       setEditModeSelectedIds(
         handleEditModeSelect(items, editModeSelectedIds, id, parentId)
       );
     } else if (selectedIds.includes(id)) {
       setSelectedIds(selectedIds.filter((item) => item !== id));
+    } else if (hasMultiSelect) {
+      setSelectedIds([...selectedIds, id]);
     } else {
-      if (hasMultiSelect) {
-        setSelectedIds([...selectedIds, id]);
-      } else {
-        setSelectedIds([id]);
-      }
+      setSelectedIds([id]);
+    }
+  };
 
-      if (onSelect) {
-        onSelect(id);
-      }
+  const handleSelect = (id, parentId = null) => {
+    setSelected(id, parentId);
+
+    if (onSelect) {
+      onSelect(id);
     }
   };
 
@@ -263,7 +265,7 @@ const HierarchyList = ({
 
         if (!isEqual(selectedIds, [defaultSelectedId])) {
           // If the defaultSelectedId prop is updated from the outside, we need to use it
-          handleSelect(defaultSelectedId);
+          setSelected(defaultSelectedId);
         }
       }
     },