Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: Add a CacheF() function to control completion cache refresh #887

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 44 additions & 3 deletions action.go
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,47 @@ func (a Action) Cache(timeout time.Duration, keys ...pkgcache.Key) Action {
return a
}

// CacheF requires a function to determine if we should use the cached data (if any and if it's
// still within timeout), and if asked to refresh it, to cache the proceeds of the invoked action.
func (a Action) CacheF(timeout time.Duration, refresh func() bool, keys ...pkgcache.Key) Action {
if a.callback == nil {
return a
}

_, file, line, _ := runtime.Caller(1)
cachedCallback := a.callback

return ActionCallback(func(c Context) Action {
// Know when the last cached values were written (if any)
cacheFile, err := cache.File(file, line, keys...)
if err != nil {
return a
}

stat, err := os.Stat(cacheFile)

// No cached results, just ask to cache after call.
cacheIsOutdated := (timeout > 0 && stat.ModTime().Add(timeout).Before(time.Now()))
if os.IsNotExist(err) || cacheIsOutdated {
return a.Cache(timeout, keys...)
}

// If we are asked to refresh the cache with new results anyway, do it.
if refresh() {
invokedAction := (Action{callback: cachedCallback}).Invoke(c)
if invokedAction.meta.Messages.IsEmpty() {
if cacheFile, err := cache.File(file, line, keys...); err == nil {
_ = cache.Write(cacheFile, invokedAction.export())
}
}
return invokedAction.ToA()
}

// Else, once again let's the cache do it's work.
return a.Cache(timeout, keys...)
})
}

// Chdir changes the current working directory to the named directory for the duration of invocation.
func (a Action) Chdir(dir string) Action {
return ActionCallback(func(c Context) Action {
Expand Down Expand Up @@ -93,14 +134,14 @@ func (a Action) Filter(values ...string) Action {
})
}

// FilterArgs filters Context.Args
// FilterArgs filters Context.Args.
func (a Action) FilterArgs() Action {
return ActionCallback(func(c Context) Action {
return a.Filter(c.Args...)
})
}

// FilterArgs filters Context.Parts
// FilterArgs filters Context.Parts.
func (a Action) FilterParts() Action {
return ActionCallback(func(c Context) Action {
return a.Filter(c.Parts...)
Expand Down Expand Up @@ -141,7 +182,7 @@ func (a Action) MultiParts(dividers ...string) Action {
})
}

// MultiPartsP is like MultiParts but with placeholders
// MultiPartsP is like MultiParts but with placeholders.
func (a Action) MultiPartsP(delimiter string, pattern string, f func(placeholder string, matches map[string]string) Action) Action {
// TODO add delimiter as suffix for proper nospace handling (some values/placeholders might appear with and without suffix)
return ActionCallback(func(c Context) Action {
Expand Down