Add SDK e2e tests #218
Merged
Add SDK e2e tests #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deadlycoconuts
force-pushed
the
add_sdk_e2e_tests
branch
15 times, most recently
from
8e4d058 to
064675c
Compare
krithika369
reviewed
Aug 1, 2022
deadlycoconuts
force-pushed
the
add_sdk_e2e_tests
branch
11 times, most recently
from
9e4bd38 to
c880789
Compare
deadlycoconuts
commented
Aug 1, 2022
| @@ -0,0 +1,219 @@ | |||
| name: Set Up Test Cluster | |||
There was a problem hiding this comment.
Created this reusable workflow since we're using it (setting up a test cluster) for both the regular e2e tests as well as the SDK e2e tests.
deadlycoconuts
commented
Aug 1, 2022
| @@ -395,7 +395,7 @@ def match_dependency(spec, name): | |||
| # conda dependencies whose spec differs slightly from Python's setuptools. | |||
| # We could install the complete conda library but this is too bulky if the goal is | |||
| # to just carry out this matching. | |||
| return spec == name or re.match(f'{name}[><=\s]+', spec) is not None | |||
| return spec == name or re.match(name + r"[><=\s]+", spec) is not None | |||
There was a problem hiding this comment.
Edited this to fix the deprecation warning about the use of \s as an escape sequence in f strings: https://github.com/gojek/turing/runs/7608305528?check_suite_focus=true#step:6:63
deadlycoconuts
force-pushed
the
add_sdk_e2e_tests
branch
3 times, most recently
from
2acd78b to
1241509
Compare
deadlycoconuts
force-pushed
the
add_sdk_e2e_tests
branch
2 times, most recently
from
575f1e9 to
dfffd9b
Compare
|
Thanks a lot for all the detailed comments! Just merged this! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
With the introduction of the Turing SDK, there has yet to be a set of e2e tests implemented to ensure that the SDK is always in sync with the development of the Turing API. This PR thus introduces a suite of e2e tests, based upon the API e2e tests, that utilise the SDK to interact with the API. Additional updates to the CI/CD workflows are also introduced to ensure that this suite completes successfully before allowing any merging/deployment from taking place.
Modifications
.github/actions/setup-test-cluster/action.yaml- Creation of a new reusable workflow from the chunk of steps found in.github/workflows/turing.yamlto create a test cluster; used when setting up a test cluster for the regular API e2e tests and the SDK e2e tests.github/workflows/turing.yaml- Introduction of atest-e2e-sdkjob to set up the test cluster and to run the test suitesdk/Makefile- Minor redefinition of the makefile to ensure that there are 2 different makefile targets, 1 for running the SDK unit tests and the other for running the SDK e2e testssdk/e2e/*- Addition of the e2e test suite for the SDK; based upon the API e2e tests