Upgrade google auth version #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 13, 2023
deadlycoconuts
added a commit
to caraml-dev/merlin
that referenced
this pull request
Jun 13, 2023
**What this PR does / why we need it**: This PR pins the version of the `caraml-auth-google` package in the SDK to `0.0.0post6`, which fixes any potential dependency conflicts between `urllib3>=2.0` and `google-auth`. See caraml-dev/caraml-sdk#5 for more details. **Which issue(s) this PR fixes**: - errors using functions/objects defined in the `google.auth` package when `urllib3>=2.0` is installed Fixes # **Does this PR introduce a user-facing change?**: ```release-note NONE ``` **Checklist** - [x] Added unit test, integration, and/or e2e tests - [x] Tested locally - [ ] Updated documentation - [ ] Update Swagger spec if the PR introduce API changes - [ ] Regenerated Golang and Python client if the PR introduce API changes
|
@deadlycoconuts Digging this PR up from its grave. The dependency should be See: https://github.com/googleapis/google-auth-library-python/blob/v2.17.3/setup.py |
|
Omg yes, did someone bump into this issue? |
Not exactly. But can you help correct this here and in Merlin / Turing SDK too? Since there are newer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR pins the version of the
google-authpackage in the SDK to>=2.17.3as it is the first release which fixes the version of itsurllib3dependency at below version2.0, because it is no longer compatible with the functions/objects defined in thegoogle-authpackage.