Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coverity defects #2469

Merged
merged 56 commits into from
Sep 18, 2024
Merged

Coverity defects #2469

merged 56 commits into from
Sep 18, 2024

Conversation

Rot127
Copy link
Collaborator

@Rot127 Rot127 commented Sep 3, 2024 •
edited
Loading

Your checklist for this pull request

  • I've documented or updated the documentation of every API function and struct this PR changes.
  • I've added tests that prove my fix is effective or that my feature works (if possible)

Detailed description

Fixes all Coverity and clang-tidy defects.
Additionally it partially fixes #2471 (too low operand count).

Test plan

Added where applicable.

Closing issues

closes #2302
closes #2475
closes #2376
closes #2438

@Rot127
Copy link
Collaborator Author

Rot127 commented Sep 5, 2024 •
edited
Loading

@R33v0LT Can you please provide me a test case for the fix in 8f91971 and c32a2a4 and da8e1ab

@Rot127
Copy link
Collaborator Author

Rot127 commented Sep 5, 2024

@imbillow Please check 20edb70

@github-actions github-actions bot added M680X Arch TriCore Arch WASM Arch labels Sep 5, 2024
@Rot127 Rot127 mentioned this pull request Sep 6, 2024
Merged
@Rot127
Copy link
Collaborator Author

Rot127 commented Sep 6, 2024 •
edited
Loading

@imbillow Also check e1e5f1c and provide me with a test case, please.

Rot127 added 24 commits September 15, 2024 07:07
@Rot127
Remove duplicated code.
a35f992
@Rot127
Add returns after CS_ASSERTS
1e83cc2
@Rot127
Check for len == 0 case.
a52ad7b
@Rot127
Ensure shift operates on uint64
891eadd
@Rot127
Replace strcpy with strncpy.
6670d4e
@Rot127
Handle edge cases for 32bit rotate
d47097e
@Rot127
Fix some out of enum warnings
2cf22f5
@Rot127
Replace a strcpy with strncpy.
9809f8d
@Rot127
Fix increment of address
68ed50f
@Rot127
Skip some linting
6a1b96e
@Rot127
Fix: set instruction id
eb353e1
@Rot127
Remove unused enum
5f5cdc5
@Rot127
Replace the last usages of strcpy with SStream functions.
94bbb1f
@Rot127
Increase number of allowed AArch64 operands.
77ebd43
@Rot127
Check safety of incrementing t the next operand.
e2ea951
@Rot127
Fix naming of operand
2a854c3
@Rot127
Update python constants
4e7463a
@Rot127
Fix option setup of CS_OPT_DETAIL_REAL
1b613fe
@Rot127
Document DETAIL_REAL has to be used with CS_OPT_ON.
16cb257
@Rot127
Run Coverity scan every Monday.
7a44c8b
@Rot127
Remove dead code
b2ab5e0
@Rot127
Fix OOB read
f8ae3b6
@Rot127
Rename macro to reflect it is only used with sstreams
e99998b
@Rot127
Fix rebase issues
9523b8d
kabeor
kabeor approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@kabeor kabeor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, merged.

@kabeor kabeor merged commit 3a2cd3c into capstone-engine:next Sep 18, 2024
19 checks passed
@XVilka
Copy link
Contributor

XVilka commented Sep 18, 2024

@kabeor could you please also merge these while you are on it (using rebase)?

They are relatively small, you can review them by checking specific commits

@Rot127 Rot127 deleted the coverity-defects branch September 19, 2024 07:53
@Rot127 Rot127 mentioned this pull request Sep 19, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kabeor kabeor kabeor approved these changes

Assignees
No one assigned
Labels
AArch64 Arch Alpha Arch ARM Arch Auto-Sync-files Auto-Sync CS-core-files auto-sync Documentation Github-files Github related files HPPA Arch LLVM-core-files auto-sync LLVM-generated-files LoongArch Arch M68K Arch M680X Arch Mips Arch MOS65XX Arch PowerPC Arch python bindings RISCV Arch SH Arch Sparc Arch SystemZ Arch TriCore Arch WASM Arch X86 Arch XCore Arch
Projects
None yet
Milestone
No milestone
3 participants
@Rot127 @XVilka @kabeor