Cleanup build process #1140
Merged
Cleanup build process #1140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
should i merge this now, or wait for a fix for pkg-config? |
|
|
|
i just tried again, there is still that issue with pkg-config: https://travis-ci.org/aquynh/capstone/jobs/380031443 |
|
@aquynh just got a comment back today from |
|
@aquynh just updated, try now! |
avoiding bash subshells (which happen in for loops) because they like to selectively inherit environment variables
|
merged, thanks! |
|
do we need this for the "next" branch? |
|
#1140 (comment) @aquynh i don't really know. want to try turning on travis you could easily do both |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
avoiding bash subshells (which happen in for loops) because they
like to selectively inherit environment variables
#1023 (comment)