preparations for python3, added pythonic critiques, added python idioms.

[grugq]

these are untested, but I believe still valid.

[danghvu]

python/capstone.py is moved to python/capstone/capstone.py so the merge is now broken.

Another note on python3, the import is broken

Python 3.3.2 (default, Sep  6 2013, 09:30:10)
[GCC 4.8.1 20130725 (prerelease)] on linux
Type "help", "copyright", "credits" or "license" for more information.
 >>> import capstone
Traceback (most recent call last):
 File "<stdin>", line 1, in <module>
File "<snip>/lib/python3.3/site-packages/capstone/__init__.py", line 1, in <module>
from capstone import cs, cs_disasm_quick, cs_version, CS_ARCH_ARM, CS_ARCH_ARM64, CS_ARCH_MIPS, CS_ARCH_X86, CS_MODE_LITTLE_ENDIAN, CS_MODE_ARM, CS_MODE_THUMB, CS_MODE_SYNTAX_INTEL, CS_MODE_16, CS_MODE_32, CS_MODE_64, CS_MODE_SYNTAX_ATT, CS_MODE_BIG_ENDIAN, CS_MODE_MICRO, CS_MODE_N64
ImportError: cannot import name cs

[aquynh]

Grugq, this file was actually orphan file, and got deleted. but i will
manually pickup some of your fixes, and port it over to the right one
(python/capstone/capstone.py)

however, you have this:

• pythonic would be: len(insn.operands)

def op_count(self, op_type):

this is not what it means: op_count() doesn't return the length of
insn.operands, but return the number of operands having the same type
@op_type.

<--- pay attention to the 2nd param.

for example, to count the number of register operands in current arm
insn, we would have:

count = insn.op_count(ARM_OP_REG)

otherwise, of course you want len(insn.operands) to get the number of
operands.

cheers,
Quynh

On Wed, Nov 27, 2013 at 4:13 PM, thaddeus t. grugq <[email protected]

wrote:

these are untested, but I believe still valid.

You can merge this Pull Request by running

git pull https://github.com/grugq/capstone master

Or view, comment on, or merge it at:

#1
Commit Summary

• preparations for python3, added pythonic critiques, added python
  idioms.

File Changes

• M bindings/python/capstone.pyhttps://github.com/preparations for python3, added pythonic critiques, added python idioms. #1/files#diff-0(14)

Patch Links:

• https://github.com/aquynh/capstone/pull/1.patch
• https://github.com/aquynh/capstone/pull/1.diff