Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: Double DESTDIR #1312

Closed
blshkv opened this issue Dec 19, 2018 · 5 comments
Closed

Makefile: Double DESTDIR #1312

blshkv opened this issue Dec 19, 2018 · 5 comments

Comments

@blshkv
Copy link
Contributor

blshkv commented Dec 19, 2018

https://github.com/aquynh/capstone/blob/master/Makefile#L76

LIBDIR = $(DESTDIR)$(PREFIX)/$(LIBDIRARCH)

https://github.com/aquynh/capstone/blob/master/Makefile#L405

mkdir -p $(DESTDIR)$(LIBDIR)
$(call install-library,$(DESTDIR)$(LIBDIR))

So the final path is:

$(DESTDIR)$(DESTDIR)$(PREFIX)/$(LIBDIRARCH)
@aquynh
Copy link
Collaborator

aquynh commented Dec 19, 2018

fixed now, please confirm.

@blshkv
Copy link
Contributor Author

blshkv commented Dec 19, 2018

 * QA Notice: files installed in ${D}/${D}:
 *   /
 *   /usr
 *   /usr/lib
 *   /usr/lib/pkgconfig
 *   /usr/lib/pkgconfig/capstone.pc

This one is not fixed yet

@aquynh
Copy link
Collaborator

aquynh commented Dec 19, 2018

just pushed another commit for this, can you try again?

aquynh added a commit that referenced this issue Dec 19, 2018
aquynh added a commit that referenced this issue Dec 19, 2018
@aquynh
Copy link
Collaborator

aquynh commented Dec 19, 2018

and another commit

@blshkv
Copy link
Contributor Author

blshkv commented Dec 19, 2018

ok, great, fixed. Thank you!

@blshkv blshkv closed this as completed Dec 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants