feat: [#1683] Adds support for subsequent sibling combinator to query selectors and match #1686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karpiuMG
force-pushed
the
1683-getbyrole-subsequent-sibling-combinator
branch
2 times, most recently
from
37036db to
72a485b
Compare
|
rerun helped |
…ator in QuerySelector
karpiuMG
force-pushed
the
1683-getbyrole-subsequent-sibling-combinator
branch
from
72a485b to
123a765
Compare
Yeah, there are some tests that are timer based and are bit flaky that needs to be fixed. Sometimes it has to do with the fetch response to github.com and npmjs.com for the integration tests. |
capricorn86
changed the title
|
Thank you for your contribution @karpiuMG! ⭐ I made a commit to improve the performance of the loop a bit, added support for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…uerySelector