feat: [1502] Reduce duplication in tests #1681
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlaviSau
commented
Jan 9, 2025
| @@ -3,22 +3,18 @@ import Response from '../../src/fetch/Response.js'; | |||
| import Headers from '../../src/fetch/Headers.js'; | |||
| import DOMException from '../../src/exception/DOMException.js'; | |||
| import DOMExceptionNameEnum from '../../src/exception/DOMExceptionNameEnum.js'; | |||
| import AbortController from '../../src/fetch/AbortController.js'; | |||
OlaviSau
force-pushed
the
feature-1502-fetch-test-improvements
branch
from
8a36bac to
73fbdc1
Compare
OlaviSau
force-pushed
the
feature-1502-fetch-test-improvements
branch
from
73fbdc1 to
4c77812
Compare
capricorn86
approved these changes
Jan 14, 2025
| @@ -30,6 +26,42 @@ const PLATFORM = | |||
| process.arch; | |||
|
|
|||
| describe('Fetch', () => { | |||
| async function mockNetwork( | |||
There was a problem hiding this comment.
I think we could move this to test/setup.ts (like mockModule()), but it doesn't have to be done in this PR
There was a problem hiding this comment.
Hmm - In that case mockAsyncNetwork for now? It's actually something to understand as to if it would be possible to make SyncFetch consistent with Fetch so mockNetwork would apply to both of them 😁
There was a problem hiding this comment.
Yes, mockAsyncNetwork would work 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll start off with some examples before fully committing as there a lot of tests. If you're happy with these changes feel free to merge this and I'll continue with the refactor. By the way, perhaps you should allow for refactor type in commit message.