Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [#1439] HTMLInputElement's Indeterminate property doesn't behave properly #1475

Merged
merged 3 commits into from
Aug 29, 2024

Conversation

malko
Copy link
Contributor

@malko malko commented Jul 2, 2024

This PR will make indeterminate property behave more properly:

  • It will not set indeterminate as an attribute but only as a property
  • It will correctly sets indeterminate state to false when HTMLInputElement type="checkbox" is clicked

@malko malko requested a review from capricorn86 as a code owner July 2, 2024 15:20
@malko
Copy link
Contributor Author

malko commented Jul 2, 2024

Copy link
Owner

@capricorn86 capricorn86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @malko! 🌟

Sorry that you had to wait for such a long time. It has been a busy summer.

@capricorn86 capricorn86 merged commit 343dfd2 into capricorn86:master Aug 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants