feat: [#1441] Support font-face #1474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, any updates or workarounds? We have a library using font-face in our project that breaks our tests, haven't found a way to work around this issue. |
capricorn86
approved these changes
Aug 29, 2024
There was a problem hiding this comment.
Thank you for your contribution @m-shaka! 🌟
Sorry that you had to wait for such a long time. It has been a busy summer.
|
I have added a unit test and support for CSSFontFaceRule.cssText. Also noticed difference for the "font-family" value compared to the browser that I fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm literally new to happy-dom and 100% not sure if this does work, but it seems like happy-dom can handle
@font-face.If I made mistakes, please fix them.
close #1441