Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [#1429] Element.insertBefore works when the node is already inserted #1453

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

juandiegombr
Copy link
Contributor

@juandiegombr juandiegombr commented Jun 3, 2024

After recent changes the Element.insertBefore is not behaving as in the browser.
When a node is inserted into a element that already contains it, it does nothing.

Fixes #1429

Browser behavior:
image

@juandiegombr juandiegombr requested a review from capricorn86 as a code owner June 3, 2024 14:08
Copy link
Owner

@capricorn86 capricorn86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @juandiegombr! 🌟

@capricorn86 capricorn86 merged commit e6f9127 into capricorn86:master Jun 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOMException: Failed to execute 'insertBefore' on 'Node'
2 participants