Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't render portals sometimes #940

Closed
llllvvuu opened this issue May 26, 2023 · 1 comment · Fixed by #1107
Closed

Can't render portals sometimes #940

llllvvuu opened this issue May 26, 2023 · 1 comment · Fixed by #1107
Assignees
@capricorn86
Labels
bug Something isn't working

Comments

@llllvvuu
Copy link

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
I don't have anything more minimal than the above sandbox, I suppose a more minimal repro would be to try to reproduce it in plain DOM. The @radix-ui/react-select code is pretty small though.

Expected behavior
jsdom renders this with no issue.

Screenshots
N/A

Device:
See linked issue

Additional context
Linked issue provides a bunch of context
@llllvvuu llllvvuu added the bug Something isn't working label May 26, 2023
@capricorn86 capricorn86 self-assigned this Oct 2, 2023
capricorn86 added a commit that referenced this issue Oct 2, 2023
@capricorn86
#940@patch: Fixes issue related to ownerDocument being null when exec…
318099e 
…uting ownerDocument.createElement() in React 18. The error occurred when rendering a Radix UI component. The root cause was that React 18 uses new DocumentFragment() (as a constructor) which was not supported.
@capricorn86 capricorn86 linked a pull request Oct 2, 2023 that will close this issue
#940@patch: Fixes issue related to ownerDocument being null when exec… #1107
Merged
capricorn86 added a commit that referenced this issue Oct 2, 2023
@capricorn86
#940@trivial: Fixes failing unit test.
96336ce
capricorn86 added a commit that referenced this issue Oct 2, 2023
@capricorn86
#940@trivial: Fixes failing unit test.
7c595e0
capricorn86 added a commit that referenced this issue Oct 2, 2023
@capricorn86
Merge pull request #1107 from capricorn86/task/940-cant-render-portal…
a4d095d 
…s-sometimes

#940@patch: Fixes issue related to ownerDocument being null when exec…
@capricorn86
Copy link
Owner

Thank you for reporting @llllvvuu! 🙂

The issue has now been fixed.

You can read more about the release here:
https://github.com/capricorn86/happy-dom/releases/tag/v12.5.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@capricorn86 capricorn86

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#940@patch: Fixes issue related to ownerDocument being null when exec… capricorn86/happy-dom
2 participants
@llllvvuu @capricorn86