Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get on a proxy key that is a Symbol causing an error #501

Closed
kalvenschraut opened this issue Jun 9, 2022 · 1 comment · Fixed by #529
Closed

Get on a proxy key that is a Symbol causing an error #501

kalvenschraut opened this issue Jun 9, 2022 · 1 comment · Fixed by #529
Labels
bug Something isn't working

Comments

@kalvenschraut
Copy link
Contributor

kalvenschraut commented Jun 9, 2022 •
edited
Loading

MicrosoftTeams-image

From looking at the that stack trace, I look at HTMLElement.js and key is a Symbol in this case so can't call .replace on it. Maybe need to check if key is not a string and key toString on it? Not to sure on the spec if it is expected for a proxy get to be triggered off a symbol access,
@capricorn86 capricorn86 added the bug Something isn't working label Jun 14, 2022
kalvenschraut added a commit to RTVision/happy-dom that referenced this issue Jul 4, 2022
@kalvenschraut
capricorn86#501@patch: allow proxy keys besides strings
2f337f6
@kalvenschraut kalvenschraut mentioned this issue Jul 4, 2022
Merged
capricorn86 added a commit that referenced this issue Jul 4, 2022
@capricorn86
Merge pull request #529 from RtVision/task/501-get-on-symbol-proxy
8c355d9 
#501@patch: allow proxy keys besides strings
@capricorn86
Copy link
Owner

capricorn86 commented Jul 4, 2022 •
edited
Loading

Thank you for your contribution @kalvenschraut! 🙂

Your fix has been released:
https://github.com/capricorn86/happy-dom/releases/tag/v6.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#501@patch: allow proxy keys besides strings RTVision/happy-dom
2 participants
@capricorn86 @kalvenschraut