Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Location.assign and Location.replace should accept URL object for url #1568

Closed
silverwind opened this issue Oct 21, 2024 · 0 comments · Fixed by #1569
Closed

Location.assign and Location.replace should accept URL object for url #1568

silverwind opened this issue Oct 21, 2024 · 0 comments · Fixed by #1569
Labels
bug Something isn't working

Comments

@silverwind
Copy link
Contributor

silverwind commented Oct 21, 2024 •
edited
Loading

Browsers convert the argument to these to string, so happy-dom should do too.

https://developer.mozilla.org/en-US/docs/Web/API/Location/assign
https://developer.mozilla.org/en-US/docs/Web/API/Location/replace

https://github.com/microsoft/TypeScript/blob/e6ef279403d86440600c866d53839a3e695220d3/src/lib/dom.generated.d.ts#L15107
https://github.com/microsoft/TypeScript/blob/e6ef279403d86440600c866d53839a3e695220d3/src/lib/dom.generated.d.ts#L15119
@silverwind silverwind added the bug Something isn't working label Oct 21, 2024
@silverwind silverwind changed the title Location.assign should accept URL object for url Location.assign and Location.replace should accept URL object for url Oct 21, 2024
@silverwind silverwind mentioned this issue Oct 21, 2024
Merged
silverwind added a commit to silverwind/happy-dom that referenced this issue Oct 21, 2024
@silverwind
fix: [capricorn86#1568] Accept URL in Location.assign and Location.re…
b122bb0 
…place
silverwind added a commit to silverwind/happy-dom that referenced this issue Oct 21, 2024
@silverwind
fix: [capricorn86#1568] Accept URL in Location.assign and Location.re…
53635bd 
…place
capricorn86 added a commit that referenced this issue Nov 6, 2024
@silverwind @capricorn86
fix: [#1568] Accept objects with a stringifier such as a URL object i…
f5e1722 
…n Location.assign and Location.replace (#1569)

Co-authored-by: David Ortner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: [#1568] Accept stringable objects in Location.assign and Location.replace silverwind/happy-dom
1 participant
@silverwind