Skip to content

Commit

Permalink
Merge pull request #1088 from capricorn86/task/1087-make-sure-that-ht…
Browse files Browse the repository at this point in the history
…mlunknownelement-unregisters-its-callback-in-customelements

#1087@patch: Makes sure that HTMLUnknownElement is disconnected from …
  • Loading branch information
capricorn86 authored Sep 22, 2023
2 parents aede90a + 86d361a commit bcb0225
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,8 @@ export default class HTMLUnknownElement extends HTMLElement implements IHTMLElem
if (newElement.isConnected && newElement.connectedCallback) {
newElement.connectedCallback();
}

this._connectToNode(null);
}
};
callbacks[tagName] = callbacks[tagName] || [];
Expand Down
16 changes: 13 additions & 3 deletions turbo.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,18 +12,28 @@
"jest-environment#compile": {
"dependsOn": ["happy-dom#compile"]
},
"integration-test#compile": {
"dependsOn": ["happy-dom#compile"]
},
"uncaught-exception-observer#compile": {
"dependsOn": ["happy-dom#compile"]
},
"happy-dom#test": {
"outputs": ["node_modules/vitest/**"]
},
"global-registrator#test": {
"dependsOn": ["happy-dom#compile"],
"dependsOn": ["happy-dom#compile", "global-registrator#compile"],
"outputs": ["tmp/**"]
},
"jest-environment#test": {
"dependsOn": ["happy-dom#compile"]
"dependsOn": ["happy-dom#compile", "jest-environment#compile"]
},
"integration-test#test": {
"dependsOn": ["happy-dom#compile"]
"dependsOn": ["happy-dom#compile", "integration-test#compile"]
},
"uncaught-exception-observer#test": {
"dependsOn": ["happy-dom#compile", "uncaught-exception-observer#compile"],
"outputs": ["tmp/**"]
},
"lint": {
"outputs": []
Expand Down

0 comments on commit bcb0225

Please sign in to comment.