Merge pull request #1212 from btea/task/0-update-match-invalid-select…

…or-regexp #0@patch: Update the regularity of the invalid selector.
capricorn86 · Feb 25, 2024 · b98ae50 · b98ae50
2 parents f522225 + 50976ce
commit b98ae50
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/packages/happy-dom/src/query-selector/QuerySelector.ts b/packages/happy-dom/src/query-selector/QuerySelector.ts
@@ -19,7 +19,7 @@ type IDocumentPositionAndElement = {
 /**
  * Invalid Selector RegExp.
  */
-const INVALID_SELECTOR_REGEXP = /^[.#\[]?\d/;
+const INVALID_SELECTOR_REGEXP = /^[.#\[]?\d|[.#]$/;
 
 /**
  * Utility for query selection in an HTML element.

diff --git a/packages/happy-dom/test/query-selector/QuerySelector.test.ts b/packages/happy-dom/test/query-selector/QuerySelector.test.ts
@@ -990,6 +990,12 @@ describe('QuerySelector', () => {
 			expect(() => div.querySelectorAll('#1')).toThrowError(
 				"Failed to execute 'querySelectorAll' on 'HTMLElement': '#1' is not a valid selector."
 			);
+			expect(() => div.querySelectorAll('a.')).toThrowError(
+				"Failed to execute 'querySelectorAll' on 'HTMLElement': 'a.' is not a valid selector."
+			);
+			expect(() => div.querySelectorAll('a#')).toThrowError(
+				"Failed to execute 'querySelectorAll' on 'HTMLElement': 'a#' is not a valid selector."
+			);
 		});
 	});
 
@@ -1178,6 +1184,12 @@ describe('QuerySelector', () => {
 			expect(() => div.querySelector('#1')).toThrowError(
 				"Failed to execute 'querySelector' on 'HTMLElement': '#1' is not a valid selector."
 			);
+			expect(() => div.querySelector('a.')).toThrowError(
+				"Failed to execute 'querySelector' on 'HTMLElement': 'a.' is not a valid selector."
+			);
+			expect(() => div.querySelector('a#')).toThrowError(
+				"Failed to execute 'querySelector' on 'HTMLElement': 'a#' is not a valid selector."
+			);
 		});
 
 		it('Has support for passing pseudoseletors inside :not', () => {