Merge pull request #1286 from rofly/master

fix: [#1285] Prevent contains from accessing properties of undefined args
capricorn86 · Mar 10, 2024 · 39d8c45 · 39d8c45
2 parents 3b4339d + 97833b3
commit 39d8c45
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/packages/happy-dom/src/nodes/node/Node.ts b/packages/happy-dom/src/nodes/node/Node.ts
@@ -297,7 +297,10 @@ export default class Node extends EventTarget implements INode {
 	 * @param otherNode Node to test with.
 	 * @returns "true" if this node contains the other node.
 	 */
-	public contains(otherNode: INode): boolean {
+	public contains(otherNode: INode | undefined): boolean {
+		if (otherNode === undefined) {
+			return false;
+		}
 		return NodeUtility.isInclusiveAncestor(this, otherNode);
 	}
 

diff --git a/packages/happy-dom/test/nodes/node/Node.test.ts b/packages/happy-dom/test/nodes/node/Node.test.ts
@@ -330,6 +330,11 @@ describe('Node', () => {
 
 			expect(div.contains(null)).toBe(false);
 		});
+		it('Returns "false" if match node is undefined.', () => {
+			const div = document.createElement('div');
+
+			expect(div.contains(undefined)).toBe(false);
+		});
 	});
 
 	describe('getRootNode()', () => {