Merge pull request #1284 from itutto/master

Fix: Fragile cloneNode implementation
capricorn86 · Mar 10, 2024 · 1eaa5f5 · 1eaa5f5
2 parents 10c7617 + ee1c28a
commit 1eaa5f5
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/packages/happy-dom/src/nodes/element/Element.ts b/packages/happy-dom/src/nodes/element/Element.ts
@@ -467,6 +467,10 @@ export default class Element extends Node implements IElement {
 	public cloneNode(deep = false): IElement {
 		const clone = <Element>super.cloneNode(deep);
 
+		clone[PropertySymbol.tagName] = this[PropertySymbol.tagName];
+		clone[PropertySymbol.localName] = this[PropertySymbol.localName];
+		clone[PropertySymbol.namespaceURI] = this[PropertySymbol.namespaceURI];
+
 		for (let i = 0, max = this[PropertySymbol.attributes].length; i < max; i++) {
 			const attribute = this[PropertySymbol.attributes][i];
 			clone[PropertySymbol.attributes].setNamedItem(
@@ -488,10 +492,6 @@ export default class Element extends Node implements IElement {
 			}
 		}
 
-		clone[PropertySymbol.tagName] = this[PropertySymbol.tagName];
-		clone[PropertySymbol.localName] = this[PropertySymbol.localName];
-		clone[PropertySymbol.namespaceURI] = this[PropertySymbol.namespaceURI];
-
 		return <IElement>clone;
 	}