MultiSegmentArena: Fix release back into bufferpool #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug that was preventing correct release of buffers allocated by Decode() back to the global buffer pool. Previously, the data variable was overriden on the loop that splits the segments, preventing the correct tracking of the full data buffer and its subsequent return back to the buffer pool when the arena was released. This also adds a .Release() call to the Decode benchmark to better reflect the ability to reuse buffers.
fpetkovski
approved these changes
Jan 8, 2025
|
@fpetkovski Just want to say "thank you" for your reviews. 🙏 @matheusd Aiming to have this reviewed in the next few days. |
|
Cool, thanks! I have another small improvement that depends on this, to be pushed after this one is merged. |
Semisol
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
LGTM, 2.4x speedup
goos: darwin
goarch: amd64
cpu: Intel(R) Xeon(R) W-2140B CPU @ 3.20GHz
BenchmarkDecode-16 [master] 130
9046418 ns/op 106.12 MB/s
5244827 B/op 50087 allocs/op
BenchmarkDecode-16 [fix-msa] 309
3732257 ns/op 257.22 MB/s
802463 B/op 10004 allocs/op
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug that was preventing correct release of buffers allocated by Decode() back to the global buffer pool.
Previously, the data variable was overriden on the loop that splits the segments, preventing the correct tracking of the full data buffer and its subsequent return back to the buffer pool when the arena was released.
This also adds a .Release() call to the Decode benchmark to better reflect the ability to reuse buffers.