-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare command with bundle exec
using SSH prefixes
#16
Conversation
@@ -33,6 +33,9 @@ Configurable options, shown here with defaults: | |||
set :bundle_without, %w{development test}.join(' ') | |||
set :bundle_binstubs, -> { shared_path.join('bin') } | |||
set :bundle_roles, :all | |||
set :bundle_bins, %w(gem rake ruby) | |||
|
|||
By default, the plugin adds `bundle exec` prefix to common executables listed in `bundle_bins` option. You can add any custom executable to this list. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should give an example on how to add an additional binary?
set :bundle_bins, fetch(:bundle_bins).push %w(my_new_binary)
or something similar?
Because I think rewriting all existing bins to only add a single one seems a bit too complex to me...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That'd be sane imho. Is there really no way to get Bundler to list binaries provided by the gems in the bundle? That seems insane.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RubyGems 2.2 is going to do something related - removing the need for bundle exec
...
There is also the rubygems-bundler gem - as already mentioned.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I'll fix the README.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Kriechi fixed.
As mentioned, RubyGems will provide something like auto- Now the question is, when RubyGems 2.2 will be released, and IF capistrano-* should work with older versions too. |
I think we have to support the old one, imagine how long it'll take to get RubyGems 2.2 into all the distros. I'm sure we could add something into |
I don't see big reasons to care about Rubygems 2.2 in this release because even after 2.2 is out, it will still have backward compatibility with |
agree! PRs will be appreciated 😃 |
end | ||
end | ||
|
||
before 'deploy:updated', 'bundler:install' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just to be picky - one space should be enough.
@kirs could you please rebase to current master. I'm getting version conflicts because this branch believes it is version 0.0.1, but the capistrano-rails gem depends on 1.0.0. Then I can test the new SSHKit prefix stuff. |
$ git rebase master
Current branch sshkit-prefixes is up to date. |
Ehm - the network shows something different: (is your local master up-to-date, maybe try pulling your master...) Or am I missing something here? |
Sorry, my fault. Now it's rebased. |
👍 It works! |
Prepare command with `bundle exec` using SSH prefixes
Here is the first implementation using SSHKit prefixes: capistrano/sshkit#45