Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for jsonpath to the CLI #127

Merged
merged 11 commits into from
May 26, 2022
Merged

Add support for jsonpath to the CLI #127

merged 11 commits into from
May 26, 2022

Conversation

blazejmalecki
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Use JSON path output template from CLI instead of jq

Related issue(s)

1. [Populate the manifests to Public Hub](../example/public-hub-content.mdx#populate-the-manifests-into-hub).
1. (For AWS only) Create a [Type Instance](../example/typeinstances.md#aws-credentials) with credentials.
1. Prepare input file `input.yaml`
2. Copy content of the `generated` directory into `manifests` directory.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to enumerate the content with 1,2,3 etc. You can read about it more here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to the previous version

docs/feature/storage-backends/helm.mdx Show resolved Hide resolved
Copy link

@mkuziemko mkuziemko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve 👍 also take a look at the comments

docs/feature/storage-backends/helm.mdx Outdated Show resolved Hide resolved
docs/feature/storage-backends/helm.mdx Show resolved Hide resolved
</TabItem>
</Tabs>
</div>
import Tabs from '@theme/Tabs';
Copy link

@mkuziemko mkuziemko May 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, the numbering started working but now we have the:

import Tabs from '@theme/Tabs'; import TabItem from '@theme/TabItem';

in the view of the Helm website.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've fixed it

Copy link

@mkuziemko mkuziemko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@mkuziemko mkuziemko merged commit 8324de9 into capactio:main May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants