-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for handle multiple backends #60
Conversation
@@ -464,7 +464,7 @@ spec: | |||
- name: basicAuth | |||
path: /yamls/basicAuth.yaml | |||
container: | |||
image: ghcr.io/capactio/pr/infra/merger:PR-428 | |||
image: ghcr.io/capactio/pr/infra/merger:20c169b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
image: ghcr.io/capactio/pr/infra/merger:20c169b | |
image: ghcr.io/capactio/pr/infra/merger:20c169b |
we cannot break this contract. All images under ghcr.io/capactio/pr/
, need to stick to PR-{number}
tag. How those images were pushed?
24a6ab9
to
a260150
Compare
a260150
to
3f32bcd
Compare
04a0e05
to
318c20e
Compare
318c20e
to
dc68958
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There where we use prepared
inputs that are merged with our merger
we shouldn't have problems, but in all places where we use capact-action: jinja2.template
with "plain" input TypeInstance we should add unpackValue
. It doesn't apply to input-parameters
which are taken directly from user input and are not part of TypeInstance concept.
IMO, places where we miss unpack option:
hub-manifests/manifests/implementation/aws/elasticsearch/install.yaml
Lines 405 to 422 in df7de74
- - name: create-es-ti capact-action: jinja2.template arguments: artifacts: - name: input-parameters from: "{{steps.terraform-apply.outputs.artifacts.additional}}" - name: configuration raw: data: | prefix: input - name: template raw: data: | version: <@ input.elasticsearch_version @> protocol: "https" host: "<@ input.endpoint @>" port: 443 basicAuthSecretName: "<@ basicAuth.metadata.name @>" hub-manifests/manifests/implementation/aws/rds/postgresql/install.yaml
Lines 217 to 237 in df7de74
- - name: render-postgresql capact-outputTypeInstances: # Defines which artifacts are output TypeInstances - name: postgresql from: render capact-action: jinja2.template arguments: artifacts: - name: input-parameters from: "{{steps.terraform-apply.outputs.artifacts.additional}}" - name: configuration raw: data: "" - name: template raw: data: | host: "<@ host @>" port: <@ port @> defaultDBName: "<@ defaultDBName @>" superuser: username: "<@ superuser.username @>" password: "<@ superuser.password @>" hub-manifests/manifests/implementation/aws/rds/postgresql/install.yaml
Lines 239 to 256 in df7de74
- - name: render-rds capact-outputTypeInstances: # Defines which artifacts are output TypeInstances - name: rds-instance from: render capact-action: jinja2.template arguments: artifacts: - name: input-parameters from: "{{steps.terraform-apply.outputs.artifacts.additional}}" - name: configuration raw: data: "" - name: template raw: data: | identifier: "<@ identifier @>" availability_zone: "<@ availability_zone @>" class: "<@ class @>" hub-manifests/manifests/implementation/aws/redis/install.yaml
Lines 233 to 250 in df7de74
- - name: render-config capact-outputTypeInstances: - name: config from: render capact-action: jinja2.template arguments: artifacts: - name: input-parameters from: "{{steps.terraform-apply.outputs.artifacts.additional}}" - name: configuration raw: data: "" - name: template raw: data: | password: "<@ elasticache_auth_token @>" port: "<@ elasticache_port @>" host: "<@ elasticache_replication_group_primary_endpoint_address @>" hub-manifests/manifests/implementation/concourse/concourse/install.yaml
Lines 120 to 133 in df7de74
- - name: render-create-db-args capact-action: jinja2.template arguments: artifacts: - name: template raw: data: | name: concoursedb owner: "<@ name @>" - name: input-parameters from: "{{steps.create-user.outputs.artifacts.user}}" - name: configuration raw: data: | hub-manifests/manifests/implementation/mattermost/mattermost-team-edition/install.yaml
Lines 127 to 140 in df7de74
- - name: render-create-db-args capact-action: jinja2.template arguments: artifacts: - name: template raw: data: | name: mattermost owner: "<@ name @>" - name: input-parameters from: "{{steps.create-user.outputs.artifacts.user}}" - name: configuration raw: data: |
But please double-check if all places really need it.
Description
Changes proposed in this pull request:
strip-value: true
for jinja.Note: Modification was only made for Mattermost manifests.
Related issue(s)