Add opt to remove TypeInstance's revision, fix update mutation #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mszostok
force-pushed
the
fix-hub-update
branch
4 times, most recently
from
0f9d7c7 to
131377c
Compare
mkuziemko
reviewed
Apr 8, 2022
mszostok
force-pushed
the
fix-hub-update
branch
2 times, most recently
from
0a4f933 to
31fe8f5
Compare
mszostok
force-pushed
the
fix-hub-update
branch
from
31fe8f5 to
2ae2bf2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
The Local Hub code was simplified thanks to handling the update logic directly in mutation resolver instead of
valuefield resolver. However, the additionall logic (rpc DeleteRevision) is now required to be implemented on each storage backend.Testing
I added e2e tests for Local Hub to prove that the contract was not broken with the new approach.
Related issue(s)
Fix #661