Implement Local Hub integration tests as separate job #683
Conversation
* First version of running hubjs tests * Test commit
|
@mkuziemko I didn't check this PR yet, but I can see that you modified only the PR build. Please also make changes to main branch pipeline and put a link to example run on your fork's |
pkosiec
added
enhancement
mkuziemko
force-pushed
the
add_localhub_tests
branch
3 times, most recently
from
274051d to
4fd26fe
Compare
mkuziemko
force-pushed
the
add_localhub_tests
branch
from
4fd26fe to
7ca8f46
Compare
| "$id": "#/properties/contextSchema/properties/name", | ||
| "type": "string", | ||
| "enum": [ | ||
| "aws_secretsmanager", |
There was a problem hiding this comment.
🤔 Why do the tests pass for creating TypeInstances without context, if our schema says it is required? We do validate the context, right? Is your PR rebased?
There was a problem hiding this comment.
Actually, if we create the TypeInstance without context then the default context is used (for use is the dotenv). Here is a place where it is checked.
mkuziemko
force-pushed
the
add_localhub_tests
branch
from
84d50a0 to
149868f
Compare
| t.Helper() | ||
| url := strings.Split(addr, ":") | ||
| assert.Equal(t, len(url), 2) | ||
| conn, err := grpc.Dial(fmt.Sprintf("[%s]:%s", url[0], url[1]), grpc.WithInsecure()) |
There was a problem hiding this comment.
Questions:
- Why do we have square brackets in the URL? What does it do?
- Can we use the
addrthere directly?
EDIT: Alright, it is for supporting IPv6 addresses: https://grpc.github.io/grpc/core/md_doc_naming.html
However, I'm not really sure if we need that 😄 We can save a few lines and use addr directly. But it's up to you, we can keep it 🙂
Description
Changes proposed in this pull request:
Testing
make test-localhubin order to run local Hub tests - it will create the env and run the tests.You can check the example execution of the tests in Github Action in my fork repository.
Related issue(s)