Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Gateway CORS by default #603

Merged
merged 1 commit into from
Jan 20, 2022
Merged

Conversation

pkosiec
Copy link
Member

@pkosiec pkosiec commented Jan 19, 2022

Description

Changes proposed in this pull request:

  • Enable Gateway CORS by default

As we have Capact Dashboard enabled by default, to make UI able to access Gateway, we need to enable CORS as well.

This change has been tested on our long-running cluster.

Related issue(s)

599

@pkosiec pkosiec added bug Something isn't working area/gateway Relates to Gateway area/dashboard Relates to Dashboard labels Jan 19, 2022
@pkosiec pkosiec added this to the 0.6.0 milestone Jan 19, 2022
Copy link

@mkuziemko mkuziemko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pkosiec pkosiec merged commit 7d56d54 into capactio:main Jan 20, 2022
@pkosiec pkosiec deleted the enable-cors branch January 20, 2022 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dashboard Relates to Dashboard area/gateway Relates to Gateway bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants