Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure map initialized before accessing it, create secret only if needed #592

Merged
merged 1 commit into from
Dec 24, 2021
Merged

Ensure map initialized before accessing it, create secret only if needed #592

merged 1 commit into from
Dec 24, 2021

Conversation

mszostok
Copy link
Member

@mszostok mszostok commented Dec 23, 2021 •
edited
Loading

Description

Changes proposed in this pull request:

  • Ensure that map is initialized before accessing it
  • Create Secret by gql service only if needed
  • Ensure that Secrets is owned by Action

Testing

Check bug description #593

Related issue(s)

Fix #593

@mszostok mszostok added bug Something isn't working area/engine Relates to Engine labels Dec 23, 2021
@mszostok mszostok added this to the 0.6.0 milestone Dec 23, 2021
@mszostok mszostok added the WIP Work in progress label Dec 23, 2021
@mszostok mszostok removed the WIP Work in progress label Dec 24, 2021
pkosiec
pkosiec approved these changes Dec 24, 2021
View reviewed changes
Copy link
Member

@pkosiec pkosiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mszostok mszostok merged commit ac72478 into capactio:main Dec 24, 2021
@mszostok mszostok deleted the panic-in-engine branch December 24, 2021 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkosiec pkosiec pkosiec approved these changes

@mkuziemko mkuziemko Awaiting requested review from mkuziemko mkuziemko is a code owner

@tmitchell tmitchell Awaiting requested review from tmitchell tmitchell is a code owner

Assignees
No one assigned
Labels
area/engine Relates to Engine bug Something isn't working
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.

During rendering, engine panics when Action has an empty Secret
2 participants
@mszostok @pkosiec