Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Describe Delegated Storage concept #583

Merged
merged 11 commits into from
Dec 23, 2021
Merged

Conversation

pkosiec
Copy link
Member

@pkosiec pkosiec commented Dec 14, 2021

Description

Changes proposed in this pull request:

  • Describe Delegated Storage concept

@pkosiec pkosiec added enhancement New feature or request WIP Work in progress area/documentation Related to all activities around documentation labels Dec 14, 2021
@pkosiec pkosiec added this to the 0.6.0 milestone Dec 14, 2021
Copy link
Member

@mszostok mszostok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, I agree with this proposal, it was easy to ready and follow 👍

IMO as a follow-up after this proposal, we start with investigations to check how we can reuse as much as we can from available projects/tools.

E.g. do an investigation if we can easily wrap the Dapr store management into this concept. I see a lot of correlation.

Other idea is to, decided that we will do the minimal scope, and all of those will be implemented with Go libs e.g. https://github.com/graymeta/stow, https://github.com/google/go-cloud just as w minimal scope. We will prove that it’s working. Next, we will extract it to dedicated services and use gRPC. Unfortunately, currently, I'm not convinced that we need the whole concept to be implemented. Of course, we need to describe the target arch, but maybe it will be beneficial to describe also midterm solution.

docs/proposal/20211207-delegated-storage.md Outdated Show resolved Hide resolved
docs/proposal/20211207-delegated-storage.md Outdated Show resolved Hide resolved
docs/proposal/20211207-delegated-storage.md Outdated Show resolved Hide resolved
docs/proposal/20211207-delegated-storage.md Outdated Show resolved Hide resolved
docs/proposal/20211207-delegated-storage.md Outdated Show resolved Hide resolved
docs/proposal/20211207-delegated-storage.md Outdated Show resolved Hide resolved
docs/proposal/20211207-delegated-storage.md Outdated Show resolved Hide resolved
docs/proposal/20211207-delegated-storage.md Outdated Show resolved Hide resolved
docs/proposal/20211207-delegated-storage.md Show resolved Hide resolved
docs/proposal/20211207-delegated-storage.md Outdated Show resolved Hide resolved
@pkosiec pkosiec marked this pull request as ready for review December 16, 2021 17:46
@pkosiec pkosiec removed the WIP Work in progress label Dec 16, 2021
Copy link
Member

@mszostok mszostok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still a few things need to be described, but as before I agree with the overall proposal 👍

docs/proposal/20211207-delegated-storage.md Outdated Show resolved Hide resolved
docs/proposal/20211207-delegated-storage.md Outdated Show resolved Hide resolved
docs/proposal/20211207-delegated-storage.md Outdated Show resolved Hide resolved
docs/proposal/20211207-delegated-storage.md Show resolved Hide resolved
docs/proposal/20211207-delegated-storage.md Outdated Show resolved Hide resolved
docs/proposal/20211207-delegated-storage.md Outdated Show resolved Hide resolved
docs/proposal/20211207-delegated-storage.md Outdated Show resolved Hide resolved
docs/proposal/20211207-delegated-storage.md Show resolved Hide resolved
docs/proposal/20211207-delegated-storage.md Show resolved Hide resolved
docs/proposal/20211207-delegated-storage.md Show resolved Hide resolved
Copy link
Member

@mszostok mszostok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was quite long “journey” but IMO we finally got it 😄 🚀

(I'm a bit scared when it comes to implement that 😄 )

@pkosiec pkosiec merged commit 21a4f72 into capactio:main Dec 23, 2021
@pkosiec pkosiec deleted the delegated-storage branch December 23, 2021 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Related to all activities around documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants